From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: implement optimized percpu variable access
Date: Tue, 27 Nov 2012 14:42:22 -0600 [thread overview]
Message-ID: <50B525AE.8010001@gmail.com> (raw)
In-Reply-To: <50B5168A.3080309@gmail.com>
On 11/27/2012 01:37 PM, Rob Herring wrote:
> On 11/27/2012 11:19 AM, Nicolas Pitre wrote:
>> On Sat, 10 Nov 2012, Rob Herring wrote:
>>
>>> From: Rob Herring <rob.herring@calxeda.com>
>>>
>>> Use the previously unused TPIDRPRW register to store percpu offsets.
>>> TPIDRPRW is only accessible in PL1, so it can only be used in the kernel.
>>>
>>> This saves 2 loads for each percpu variable access which should yield
>>> improved performance, but the improvement has not been quantified.
>>>
>>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>>
>> I've just got around to wrap my brain around this patch and the
>> discussion that ensued.
>>
>> Isn't your patch lacking the preserving and restoring of the TPIDRPRW in
>> the suspend and resume paths.
>
> Why yes, you are right. And I noticed the v6 save/restore is missing the
> user thread ID for v6K as well. I haven't looked closer, but perhaps it
> is never used.
Moving the setup from secondary_start_kernel to cpu_init will address
this. cpu_init is called for both secondary boot and resume of the boot
cpu. There is no need to save it, we can just reinitialize.
Rob
next prev parent reply other threads:[~2012-11-27 20:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 3:20 [PATCH] ARM: implement optimized percpu variable access Rob Herring
2012-11-12 10:23 ` Will Deacon
2012-11-12 13:03 ` Rob Herring
2012-11-12 13:28 ` Will Deacon
2012-11-12 14:03 ` Rob Herring
2012-11-27 17:29 ` Nicolas Pitre
2012-11-12 14:21 ` Rob Herring
2012-11-12 14:41 ` Will Deacon
2012-11-12 16:51 ` Will Deacon
2012-11-12 21:01 ` Rob Herring
2012-11-13 10:40 ` Will Deacon
2012-11-22 11:34 ` Will Deacon
2012-11-22 11:39 ` Russell King - ARM Linux
2012-11-23 17:06 ` Rob Herring
2012-11-23 17:12 ` Russell King - ARM Linux
2012-11-23 17:16 ` Will Deacon
2012-11-23 20:34 ` Tony Lindgren
2012-11-23 20:32 ` Tony Lindgren
2012-11-25 18:46 ` Rob Herring
2012-11-26 11:13 ` Will Deacon
2012-11-26 15:15 ` Will Deacon
2012-11-26 17:30 ` Rob Herring
2012-11-27 13:17 ` Will Deacon
2012-11-27 13:26 ` Russell King - ARM Linux
2012-11-26 21:58 ` Jamie Lokier
2012-11-26 23:50 ` Jamie Lokier
2012-11-27 1:02 ` Jamie Lokier
2012-11-27 22:02 ` Rob Herring
2012-11-28 12:34 ` Will Deacon
2012-11-27 17:35 ` Nicolas Pitre
2012-11-27 19:27 ` Nicolas Pitre
2012-11-27 17:19 ` Nicolas Pitre
2012-11-27 19:37 ` Rob Herring
2012-11-27 20:42 ` Rob Herring [this message]
2012-11-27 22:02 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B525AE.8010001@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).