* [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
@ 2012-12-10 1:07 Kukjin Kim
2012-12-10 2:16 ` Joonyoung Shim
0 siblings, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2012-12-10 1:07 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
arch/arm/mach-exynos/common.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
index 0eb3b9a..9ecda37 100644
--- a/arch/arm/mach-exynos/common.c
+++ b/arch/arm/mach-exynos/common.c
@@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
* Theses parameters should be NULL and 0 because EXYNOS4
* uses GIC instead of VIC.
*/
- s5p_init_irq(NULL, 0);
+ if (!of_machine_is_compatible("samsung,exynos5440"))
+ s5p_init_irq(NULL, 0);
gic_arch_extn.irq_set_wake = s3c_irq_wake;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
2012-12-10 1:07 [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440 Kukjin Kim
@ 2012-12-10 2:16 ` Joonyoung Shim
2012-12-19 3:26 ` Kukjin Kim
0 siblings, 1 reply; 4+ messages in thread
From: Joonyoung Shim @ 2012-12-10 2:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 12/10/2012 10:07 AM, Kukjin Kim wrote:
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 0eb3b9a..9ecda37 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
> * Theses parameters should be NULL and 0 because EXYNOS4
> * uses GIC instead of VIC.
> */
> - s5p_init_irq(NULL, 0);
> + if (!of_machine_is_compatible("samsung,exynos5440"))
> + s5p_init_irq(NULL, 0);
How about remove to call s5p_init_irq() here because All exynos SoCs use
GIC instead of VIC?
>
> gic_arch_extn.irq_set_wake = s3c_irq_wake;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
2012-12-10 2:16 ` Joonyoung Shim
@ 2012-12-19 3:26 ` Kukjin Kim
2012-12-20 2:04 ` Joonyoung Shim
0 siblings, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2012-12-19 3:26 UTC (permalink / raw)
To: linux-arm-kernel
Joonyoung Shim wrote:
>
> Hi,
>
> On 12/10/2012 10:07 AM, Kukjin Kim wrote:
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > arch/arm/mach-exynos/common.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
> exynos/common.c
> > index 0eb3b9a..9ecda37 100644
> > --- a/arch/arm/mach-exynos/common.c
> > +++ b/arch/arm/mach-exynos/common.c
> > @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
> > * Theses parameters should be NULL and 0 because EXYNOS4
> > * uses GIC instead of VIC.
> > */
> > - s5p_init_irq(NULL, 0);
> > + if (!of_machine_is_compatible("samsung,exynos5440"))
> > + s5p_init_irq(NULL, 0);
>
> How about remove to call s5p_init_irq() here because All exynos SoCs use
> GIC instead of VIC?
>
NO, the current s5p_init_irq() is not only for VIC but also Timer which is
used on EXYNOS SoCs, I know the name is strange...
> > gic_arch_extn.irq_set_wake = s3c_irq_wake;
> > }
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
2012-12-19 3:26 ` Kukjin Kim
@ 2012-12-20 2:04 ` Joonyoung Shim
0 siblings, 0 replies; 4+ messages in thread
From: Joonyoung Shim @ 2012-12-20 2:04 UTC (permalink / raw)
To: linux-arm-kernel
On 12/19/2012 12:26 PM, Kukjin Kim wrote:
> Joonyoung Shim wrote:
>> Hi,
>>
>> On 12/10/2012 10:07 AM, Kukjin Kim wrote:
>>> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>>> ---
>>> arch/arm/mach-exynos/common.c | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
>> exynos/common.c
>>> index 0eb3b9a..9ecda37 100644
>>> --- a/arch/arm/mach-exynos/common.c
>>> +++ b/arch/arm/mach-exynos/common.c
>>> @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
>>> * Theses parameters should be NULL and 0 because EXYNOS4
>>> * uses GIC instead of VIC.
>>> */
>>> - s5p_init_irq(NULL, 0);
>>> + if (!of_machine_is_compatible("samsung,exynos5440"))
>>> + s5p_init_irq(NULL, 0);
>> How about remove to call s5p_init_irq() here because All exynos SoCs use
>> GIC instead of VIC?
>>
> NO, the current s5p_init_irq() is not only for VIC but also Timer which is
> used on EXYNOS SoCs, I know the name is strange...
I think timer can be selective by MCT on Exynos SoCs.
The patch(ARM: EXYNOS: remove static mapping of PWM memory) is for it.
>>> gic_arch_extn.irq_set_wake = s3c_irq_wake;
>>> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-20 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 1:07 [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440 Kukjin Kim
2012-12-10 2:16 ` Joonyoung Shim
2012-12-19 3:26 ` Kukjin Kim
2012-12-20 2:04 ` Joonyoung Shim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).