From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Tue, 11 Dec 2012 17:00:37 +0400 Subject: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree In-Reply-To: <1355223525-19165-1-git-send-email-Julia.Lawall@lip6.fr> References: <1355223525-19165-1-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <50C72E75.8030706@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 11-12-2012 14:58, Julia Lawall wrote: > From: Julia Lawall > The function at91_dt_node_to_map is ultimately called by the function > pinctrl_get, which is an exported function. Since it is possible that this > function is not called from within a probe function, for safety, the kfree > is converted to a devm_kfree, to both free the data and remove it from the > device in a failure situation. > A newline is added in the call to devm_kfree to avoid exceeding the 80 devm_kzalloc() you mean? > character limit. > Signed-off-by: Julia Lawall > --- > drivers/pinctrl/pinctrl-at91.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index c5e7571..0da8a5f 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -255,7 +255,8 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev, > } > > map_num += grp->npins; > - new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num, GFP_KERNEL); > + new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num, > + GFP_KERNEL); WBR, Sergei