* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
@ 2012-12-17 16:11 Will Deacon
2012-12-18 10:14 ` Marc Zyngier
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Will Deacon @ 2012-12-17 16:11 UTC (permalink / raw)
To: linux-arm-kernel
Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
private memory region") accidentally broke the definition for the base
address of the private peripheral region on revision B Realview-EB
boards.
This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
Cc: Marc Zyngier <marc.zyngier@arm.com>
Tested-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h
index 124bce6..a301e61 100644
--- a/arch/arm/mach-realview/include/mach/board-eb.h
+++ b/arch/arm/mach-realview/include/mach/board-eb.h
@@ -47,7 +47,7 @@
#define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */
#ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000
#define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */
#define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */
#else
--
1.8.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-17 16:11 [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards Will Deacon
@ 2012-12-18 10:14 ` Marc Zyngier
2012-12-18 10:17 ` Marc Zyngier
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2012-12-18 10:14 UTC (permalink / raw)
To: linux-arm-kernel
On 17/12/12 16:11, Will Deacon wrote:
> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
> private memory region") accidentally broke the definition for the base
> address of the private peripheral region on revision B Realview-EB
> boards.
>
> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Tested-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h
> index 124bce6..a301e61 100644
> --- a/arch/arm/mach-realview/include/mach/board-eb.h
> +++ b/arch/arm/mach-realview/include/mach/board-eb.h
> @@ -47,7 +47,7 @@
> #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */
>
> #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
> -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000
> +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000
> #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */
> #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */
> #else
>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-17 16:11 [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards Will Deacon
2012-12-18 10:14 ` Marc Zyngier
@ 2012-12-18 10:17 ` Marc Zyngier
2012-12-18 10:19 ` Marc Zyngier
2012-12-18 10:25 ` Marc Zyngier
3 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2012-12-18 10:17 UTC (permalink / raw)
To: linux-arm-kernel
On 17/12/12 16:11, Will Deacon wrote:
> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
> private memory region") accidentally broke the definition for the base
> address of the private peripheral region on revision B Realview-EB
> boards.
>
> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Tested-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h
> index 124bce6..a301e61 100644
> --- a/arch/arm/mach-realview/include/mach/board-eb.h
> +++ b/arch/arm/mach-realview/include/mach/board-eb.h
> @@ -47,7 +47,7 @@
> #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */
>
> #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
> -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000
> +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000
> #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */
> #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */
> #else
>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-17 16:11 [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards Will Deacon
2012-12-18 10:14 ` Marc Zyngier
2012-12-18 10:17 ` Marc Zyngier
@ 2012-12-18 10:19 ` Marc Zyngier
2012-12-18 10:25 ` Marc Zyngier
3 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2012-12-18 10:19 UTC (permalink / raw)
To: linux-arm-kernel
On 17/12/12 16:11, Will Deacon wrote:
> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
> private memory region") accidentally broke the definition for the base
> address of the private peripheral region on revision B Realview-EB
> boards.
>
> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Tested-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h
> index 124bce6..a301e61 100644
> --- a/arch/arm/mach-realview/include/mach/board-eb.h
> +++ b/arch/arm/mach-realview/include/mach/board-eb.h
> @@ -47,7 +47,7 @@
> #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */
>
> #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
> -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000
> +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000
> #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */
> #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */
> #else
>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-17 16:11 [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards Will Deacon
` (2 preceding siblings ...)
2012-12-18 10:19 ` Marc Zyngier
@ 2012-12-18 10:25 ` Marc Zyngier
2012-12-18 10:38 ` Marc Zyngier
3 siblings, 1 reply; 7+ messages in thread
From: Marc Zyngier @ 2012-12-18 10:25 UTC (permalink / raw)
To: linux-arm-kernel
On 17/12/12 16:11, Will Deacon wrote:
> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
> private memory region") accidentally broke the definition for the base
> address of the private peripheral region on revision B Realview-EB
> boards.
>
> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Tested-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h
> index 124bce6..a301e61 100644
> --- a/arch/arm/mach-realview/include/mach/board-eb.h
> +++ b/arch/arm/mach-realview/include/mach/board-eb.h
> @@ -47,7 +47,7 @@
> #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */
>
> #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
> -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000
> +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000
> #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */
> #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */
> #else
>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-18 10:25 ` Marc Zyngier
@ 2012-12-18 10:38 ` Marc Zyngier
2012-12-18 10:48 ` Will Deacon
0 siblings, 1 reply; 7+ messages in thread
From: Marc Zyngier @ 2012-12-18 10:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 18 Dec 2012 10:25:52 +0000, Marc Zyngier <marc.zyngier@arm.com>
wrote:
> On 17/12/12 16:11, Will Deacon wrote:
>> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
>> private memory region") accidentally broke the definition for the base
>> address of the private peripheral region on revision B Realview-EB
>> boards.
>>
>> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
>>
>> Cc: Marc Zyngier <marc.zyngier@arm.com>
>> Tested-by: Florian Fainelli <florian@openwrt.org>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
The ARM email server seems to be acting up. Sorry for the noise.
M.
--
Fast, cheap, reliable. Pick two.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards
2012-12-18 10:38 ` Marc Zyngier
@ 2012-12-18 10:48 ` Will Deacon
0 siblings, 0 replies; 7+ messages in thread
From: Will Deacon @ 2012-12-18 10:48 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 18, 2012 at 10:38:20AM +0000, Marc Zyngier wrote:
> On Tue, 18 Dec 2012 10:25:52 +0000, Marc Zyngier <marc.zyngier@arm.com>
> wrote:
> > On 17/12/12 16:11, Will Deacon wrote:
> >> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore
> >> private memory region") accidentally broke the definition for the base
> >> address of the private peripheral region on revision B Realview-EB
> >> boards.
> >>
> >> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.
> >>
> >> Cc: Marc Zyngier <marc.zyngier@arm.com>
> >> Tested-by: Florian Fainelli <florian@openwrt.org>
> >> Signed-off-by: Will Deacon <will.deacon@arm.com>
> >
> > Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
> The ARM email server seems to be acting up. Sorry for the noise.
Damn, I just thought you were really into the patch.
Will
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-12-18 10:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-17 16:11 [PATCH] ARM: realview: fix private peripheral memory base for EB rev. B boards Will Deacon
2012-12-18 10:14 ` Marc Zyngier
2012-12-18 10:17 ` Marc Zyngier
2012-12-18 10:19 ` Marc Zyngier
2012-12-18 10:25 ` Marc Zyngier
2012-12-18 10:38 ` Marc Zyngier
2012-12-18 10:48 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).