From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: pxa: palm27x: fix udc device initialization
Date: Thu, 27 Dec 2012 05:16:16 -0800 [thread overview]
Message-ID: <50DC4A20.3080702@newsguy.com> (raw)
In-Reply-To: <87sj6vmpkr.fsf@free.fr>
Hi Robert,
On 12/24/2012 07:34 AM, Robert Jarzmik wrote:
[..]
Actually gpio-vbus was designed to :
> - detect and handle VBus
> - and handle following D+ pullup if peripheral controller *can't*
>
> But pxa27x_udc is a peripheral controller which does handle D+ pullup, and
> expects to handle it by himself (ie. is not fully compatible with a D+ pullup
> handling by gpio-vbus, one not working case being Mike's one).
>
> So Mike's patch makes sense IMHO. He could have left the VBUS handling to
> gpio-vbus and D+ to pxa27x_udc, or let pxa27x_udc handle both, that's up to you.
I didn't realize the pxa27x-udc driver could handle the vbus as well.
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Thanks Robert. Should have CC'd you, since you're the udc driver author. Glad
you saw this.
Thanks again,
MIke
next prev parent reply other threads:[~2012-12-27 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 18:27 [PATCH 0/2] ARM: pxa: palm27x: device initialization fixes Mike Dunn
2012-12-22 18:27 ` [PATCH 1/2] ARM: pxa: palm27x: fix udc device initialization Mike Dunn
2012-12-23 3:24 ` Marek Vasut
2012-12-24 15:34 ` Robert Jarzmik
2012-12-27 13:16 ` Mike Dunn [this message]
2012-12-22 18:27 ` [PATCH 2/2] ARM: pxa: palm27x: fix lcd " Mike Dunn
2012-12-23 3:24 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DC4A20.3080702@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).