From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa27x: fix ac97 controller warm reset code
Date: Fri, 28 Dec 2012 13:07:28 -0800 [thread overview]
Message-ID: <50DE0A10.8040606@newsguy.com> (raw)
In-Reply-To: <87sj6qrpz7.fsf@free.fr>
Hi Roert, thanks again.
On 12/28/2012 10:28 AM, Robert Jarzmik wrote:
> Mike Dunn <mikedunn@newsguy.com> writes:
>
>> This patch fixes some code that implements a work-around to a hardware bug in
>> the ac97 controller on the pxa27x. A bug in the controller's warm reset
>> functionality requires that the mfp used by the controller as the AC97_RESET_n
>> line be temporarily reconfigured as a generic output gpio (AF0) and manually
>> held high for the duration of the warm reset cycle. This is what was done in
>> the original code, but it was broken long ago by commit
>> fb1bf8cd13bfa7ed0364ab0d82f717fc020d35f6, which changed the mfp to a GPIO input
>> instead of a high output.
>>
>> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> As a side note, shouldn't this patch (as the other one on ALSA), once reviewed,
> be submitted to stable kernel ?
Dunno. I'm kind of a newbie. If the stable tree is for urgent fixes, well,
these have been broken for a long time.
Happy New Year!
Mike
next prev parent reply other threads:[~2012-12-28 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 14:52 [PATCH] ARM: pxa27x: fix ac97 controller warm reset code Mike Dunn
2012-12-28 18:28 ` Robert Jarzmik
2012-12-28 21:07 ` Mike Dunn [this message]
2012-12-28 19:49 ` Sergei Shtylyov
2012-12-28 21:04 ` Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DE0A10.8040606@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).