From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH Resend] ARM: pxa27x: fix ac97 controller warm reset code
Date: Mon, 31 Dec 2012 13:04:14 -0800 [thread overview]
Message-ID: <50E1FDCE.4010101@newsguy.com> (raw)
In-Reply-To: <50E1613B.9040403@compulab.co.il>
On 12/31/2012 01:56 AM, Igor Grinberg wrote:
> On 12/28/12 23:06, Mike Dunn wrote:
[..]
>>
>> static unsigned long ac97_reset_config[] = {
>> - GPIO113_GPIO,
>> + MFP_CFG_OUT(GPIO113, AF0, DRIVE_HIGH),
>> GPIO113_AC97_nRESET,
>> - GPIO95_GPIO,
>> + MFP_CFG_OUT(GPIO95, AF0, DRIVE_HIGH),
>
> It was always discouraged to code the above directly.
Had a funny feeling about that when I coded it... I should have heeded the
feeling instead of being hasty.
> How about one of the below:
> 1)
> GPIO113_GPIO | MFP_PULL_HIGH,
> GPIO95_GPIO | MFP_PULL_HIGH,
>
> or
>
> 2) introduce something like:
> GPIO113_AC97_nRESET_GPIO_HIGH
> GPIO95_AC97_nRESET_GPIO_HIGH
> in the mfp-pxa27x.h file and use them in the structure above.
OK, will implement your suggestion and resubmit. To me, your first option seems
clearer to the casual reader.
Thanks Igor,
Mike
next prev parent reply other threads:[~2012-12-31 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 21:06 [PATCH Resend] ARM: pxa27x: fix ac97 controller warm reset code Mike Dunn
2012-12-31 9:56 ` Igor Grinberg
2012-12-31 21:04 ` Mike Dunn [this message]
2013-01-01 12:40 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E1FDCE.4010101@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).