From: pgaikwad@nvidia.com (Prashant Gaikwad)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 05/11] ARM: dt: tegra30: Add device node for APB MISC
Date: Fri, 4 Jan 2013 07:18:00 +0530 [thread overview]
Message-ID: <50E634D0.6080702@nvidia.com> (raw)
In-Reply-To: <50E5ADA6.1070904@wwwdotorg.org>
On Thursday 03 January 2013 09:41 PM, Stephen Warren wrote:
> On 01/02/2013 11:11 PM, Prashant Gaikwad wrote:
>> On Thursday 03 January 2013 03:30 AM, Stephen Warren wrote:
>>> On 12/27/2012 07:47 AM, Prashant Gaikwad wrote:
>>>> APB misc contains multiple registers required by different modules
>>>> such as CAR.
>>> I don't see a DT binding document that describes what
>>> nvidia,tegra30-apbmisc means. Also, the register range for this new node
>>> overlaps that for the pinmux node, so they can't both "request" their
>>> register region. You may need multiple entries in the apbmisc reg
>>> property to avoid this.
>> apbmisc reg for Tegra30 can be divided into following entries:
>>
>> strap registers
>> jtag configuration registers
>> pull_up/pull_down control registers
>> vclk control registers
>> tvdac registers
>> chip id revision registers
>> pad control registers
>>
>> This list is not same for Tegra20 and Tegra30.
> OK. It sounds like we need a true APB MISC driver then, to abstract the
> differences; the clock driver really shouldn't be touching the APB MISC
> registers in all likelihood, unless a subset of the sections you mention
> above are truly dedicated to clock functionality.
I don't think it is a good idea to create a driver for APB MISC, all
registers are used by different drivers.
Only chip id revision registers are used in clock driver.
>> OR
>>
>> another way is to add chip id revision register region to CAR node as
>> done for pinmux node and remove apb misc node.
> The pinmux controller doesn't have a reg entry for the chip ID register.
> I don't understand what you mean here.
I mean as we have separate entry for PAD control registers region in
pinmux node we can have also have separate entry for chid id revision
register region in CAR node.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-04 1:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 14:47 [PATCH v2 00/11] Migrate Tegra to common clock framework Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 01/11] clk: tegra: Add tegra specific clocks Prashant Gaikwad
2013-01-07 12:13 ` Peter De Schrijver
2012-12-27 14:47 ` [PATCH v2 02/11] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 03/11] ARM: tegra: Define Tegra20 CAR binding Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 04/11] ARM: Tegra: Define Tegra30 " Prashant Gaikwad
2013-01-09 14:41 ` Peter De Schrijver
2012-12-27 14:47 ` [PATCH v2 05/11] ARM: dt: tegra30: Add device node for APB MISC Prashant Gaikwad
2013-01-02 22:00 ` Stephen Warren
2013-01-03 6:11 ` Prashant Gaikwad
2013-01-03 16:11 ` Stephen Warren
2013-01-04 1:48 ` Prashant Gaikwad [this message]
2013-01-04 3:05 ` Stephen Warren
2013-01-04 3:23 ` Prashant Gaikwad
2013-01-04 4:00 ` Stephen Warren
2013-01-04 4:26 ` Prashant Gaikwad
2013-01-04 5:21 ` Stephen Warren
2013-01-04 5:31 ` Prashant Gaikwad
2013-01-04 11:56 ` Laxman Dewangan
2013-01-04 19:57 ` Stephen Warren
2012-12-27 14:47 ` [PATCH v2 06/11] ARM: dt: tegra20: " Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 07/11] clk: tegra: add clock support for tegra20 Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 08/11] clk: tegra: add clock support for tegra30 Prashant Gaikwad
2013-01-07 14:54 ` Peter De Schrijver
2012-12-27 14:47 ` [PATCH v2 09/11] clk: tegra: add dt support Prashant Gaikwad
2013-01-02 22:06 ` Stephen Warren
2012-12-27 14:47 ` [PATCH v2 10/11] arm: tegra: Migrate to new clock code Prashant Gaikwad
2012-12-27 14:47 ` [PATCH v2 11/11] arm: tegra: Remove legacy " Prashant Gaikwad
2013-01-02 22:09 ` [PATCH v2 00/11] Migrate Tegra to common clock framework Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E634D0.6080702@nvidia.com \
--to=pgaikwad@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).