linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: OMAP4: clock data: Lock ABE DPLL on all revisions
Date: Fri, 4 Jan 2013 16:46:21 +0100	[thread overview]
Message-ID: <50E6F94D.7090706@ti.com> (raw)
In-Reply-To: <50E6F0CA.60309@ti.com>

On 01/04/2013 04:10 PM, Jon Hunter wrote:
> 
> On 01/04/2013 04:09 AM, Peter Ujfalusi wrote:
>> To avoid issues with audio caused by non locked ABE DPLL we should
>> make sure it is locked in all OMAP4 revisions.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>
>> asda d
> 
> Not sure what the above is ;-)

Argh, squashed patches without commit message cleanup...
Paul: can you fix this up, or should I resend?

> 
>> ---
>>  arch/arm/mach-omap2/cclock44xx_data.c | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>> index 5789a5e..a2cc046 100644
>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>> @@ -2026,14 +2026,13 @@ int __init omap4xxx_clk_init(void)
>>  	 * On OMAP4460 the ABE DPLL fails to turn on if in idle low-power
>>  	 * state when turning the ABE clock domain. Workaround this by
>>  	 * locking the ABE DPLL on boot.
>> +	 * Lock the ABE DPLL in any case to avoid issues with audio.
>>  	 */
>> -	if (cpu_is_omap446x()) {
>> -		rc = clk_set_parent(&abe_dpll_refclk_mux_ck, &sys_32k_ck);
>> -		if (!rc)
>> -			rc = clk_set_rate(&dpll_abe_ck, OMAP4_DPLL_ABE_DEFFREQ);
>> -		if (rc)
>> -			pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>> -	}
>> +	rc = clk_set_parent(&abe_dpll_refclk_mux_ck, &sys_32k_ck);
>> +	if (!rc)
>> +		rc = clk_set_rate(&dpll_abe_ck, OMAP4_DPLL_ABE_DEFFREQ);
>> +	if (rc)
>> +		pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>>  
>>  	return 0;
>>  }
> 
> Acked-by: Jon Hunter <jon-hunter@ti.com>
> 
> Cheers
> Jon
> 


-- 
P?ter

  reply	other threads:[~2013-01-04 15:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 10:09 [PATCH v2 0/2] ARM: OMAP4: Audio regression fix for 3.8 kernel Peter Ujfalusi
2013-01-04 10:09 ` [PATCH v2 1/2] ARM: OMAP4: clock data: Lock ABE DPLL on all revisions Peter Ujfalusi
2013-01-04 15:10   ` Jon Hunter
2013-01-04 15:46     ` Peter Ujfalusi [this message]
2013-01-04 17:18       ` Paul Walmsley
2013-01-04 17:11     ` Russell King - ARM Linux
2013-01-04 10:09 ` [PATCH v2 2/2] ARM: OMAP4: hwmod_data: Correct IDLEMODE for McPDM Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E6F94D.7090706@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).