From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ALSA: pxa2xx: fix ac97 cold reset
Date: Mon, 07 Jan 2013 15:57:16 +0200 [thread overview]
Message-ID: <50EAD43C.2040406@compulab.co.il> (raw)
In-Reply-To: <50EACF4D.4000602@newsguy.com>
On 01/07/13 15:36, Mike Dunn wrote:
> On 01/07/2013 01:16 AM, Igor Grinberg wrote:
>> On 01/06/13 21:13, Mike Dunn wrote:
>
>
> [..]
>
>
>>> static inline void pxa_ac97_cold_pxa27x(void)
>>> {
>>> + unsigned int timeout;
>>> +
>>> GCR &= GCR_COLD_RST; /* clear everything but nCRST */
>>> GCR &= ~GCR_COLD_RST; /* then assert nCRST */
>>>
>>> @@ -157,8 +159,10 @@ static inline void pxa_ac97_cold_pxa27x(void)
>>> clk_enable(ac97conf_clk);
>>> udelay(5);
>>> clk_disable(ac97conf_clk);
>>> - GCR = GCR_COLD_RST;
>>> - udelay(50);
>>> + GCR = GCR_COLD_RST | GCR_WARM_RST;
>>> + timeout = 100; /* wait for the codec-ready bit to be set */
>>> + while (!((GSR | gsr_bits) & (GSR_PCR | GSR_SCR)) && timeout--)
>>> + mdelay(1);
>>
>> Can we use msleep() instead?
>> May be this will require to change the granularity to 10...
>
>
> Probably. mdelay() is used by similiar code in the same file, so I just stayed
> consistent. The code runs very infrequently, so I didn't worry about it.
Well, if we can, I think we'd better do, no?
--
Regards,
Igor.
next prev parent reply other threads:[~2013-01-07 13:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 19:13 [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Mike Dunn
2013-01-06 19:13 ` [PATCH 1/4] ALSA: pxa2xx: fix ac97 cold reset Mike Dunn
2013-01-07 9:16 ` Igor Grinberg
2013-01-07 13:36 ` Mike Dunn
2013-01-07 13:57 ` Igor Grinberg [this message]
2013-01-07 14:19 ` Mike Dunn
2013-01-07 15:28 ` Igor Grinberg
2013-01-06 19:13 ` [PATCH 2/4] ALSA: pxa27x: fix ac97 warm reset bug work-around code Mike Dunn
2013-01-07 9:31 ` Igor Grinberg
2013-01-07 11:06 ` Russell King - ARM Linux
2013-01-07 13:40 ` Mike Dunn
2013-01-06 19:13 ` [PATCH 3/4] ALSA: pxa27x: ac97 controller driver requests gpio Mike Dunn
2013-01-07 9:36 ` Igor Grinberg
2013-01-07 9:42 ` Igor Grinberg
2013-01-07 14:10 ` Mike Dunn
2013-01-07 15:38 ` Igor Grinberg
2013-01-07 16:40 ` Mike Dunn
2013-01-06 19:14 ` [PATCH 4/4] ALSA: pxa27x: rename pxa27x_assert_ac97() Mike Dunn
2013-01-07 9:39 ` Igor Grinberg
2013-01-07 14:34 ` Mike Dunn
2013-01-07 15:41 ` Igor Grinberg
2013-01-06 20:33 ` [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EAD43C.2040406@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).