From mboxrd@z Thu Jan  1 00:00:00 1970
From: grinberg@compulab.co.il (Igor Grinberg)
Date: Mon, 07 Jan 2013 15:57:16 +0200
Subject: [PATCH 1/4] ALSA: pxa2xx: fix ac97 cold reset
In-Reply-To: <50EACF4D.4000602@newsguy.com>
References: <1357499640-13871-1-git-send-email-mikedunn@newsguy.com>
 <1357499640-13871-2-git-send-email-mikedunn@newsguy.com>
 <50EA9287.5030304@compulab.co.il> <50EACF4D.4000602@newsguy.com>
Message-ID: <50EAD43C.2040406@compulab.co.il>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 01/07/13 15:36, Mike Dunn wrote:
> On 01/07/2013 01:16 AM, Igor Grinberg wrote:
>> On 01/06/13 21:13, Mike Dunn wrote:
> 
> 
> [..]
> 
> 
>>>  static inline void pxa_ac97_cold_pxa27x(void)
>>>  {
>>> +	unsigned int timeout;
>>> +
>>>  	GCR &=  GCR_COLD_RST;  /* clear everything but nCRST */
>>>  	GCR &= ~GCR_COLD_RST;  /* then assert nCRST */
>>>  
>>> @@ -157,8 +159,10 @@ static inline void pxa_ac97_cold_pxa27x(void)
>>>  	clk_enable(ac97conf_clk);
>>>  	udelay(5);
>>>  	clk_disable(ac97conf_clk);
>>> -	GCR = GCR_COLD_RST;
>>> -	udelay(50);
>>> +	GCR = GCR_COLD_RST | GCR_WARM_RST;
>>> +	timeout = 100;     /* wait for the codec-ready bit to be set */
>>> +	while (!((GSR | gsr_bits) & (GSR_PCR | GSR_SCR)) && timeout--)
>>> +		mdelay(1);
>>
>> Can we use msleep() instead?
>> May be this will require to change the granularity to 10...
> 
> 
> Probably.  mdelay() is used by similiar code in the same file, so I just stayed
> consistent.  The code runs very infrequently, so I didn't worry about it.

Well, if we can, I think we'd better do, no?


-- 
Regards,
Igor.