From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ALSA: pxa27x: rename pxa27x_assert_ac97()
Date: Mon, 07 Jan 2013 06:34:33 -0800 [thread overview]
Message-ID: <50EADCF9.10307@newsguy.com> (raw)
In-Reply-To: <50EA97EA.4030807@compulab.co.il>
On 01/07/2013 01:39 AM, Igor Grinberg wrote:
>
>
> On 01/06/13 21:14, Mike Dunn wrote:
>> This patch does nothing functionally, it just gives the function a new name and
>> modifies the prototype slightly in order to clarify what the function is doing
>> (which is not necessarily asserting the reset).
>> Some commentary also added.
>>
>> Tested on a palm treo 680 machine.
>>
>> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
>
> This patch makes sense, but again raising your concern...
> The gpio_direction_output(reset_gpio, 1) should be called after
> the change to AF0.
Can you clarify please? Don't you mean *before* the change to AF0? The proper
values must be set in the GPDR and GPSR/GPCR before changing to AF0, no? This
not only makes intuitive sense, it is also consistent with the information in
the pxa270 developer's manual. Once AF0 is set, the last values that were set
for direction and level take immediate effect, no?
Thanks,
Mike
next prev parent reply other threads:[~2013-01-07 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 19:13 [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Mike Dunn
2013-01-06 19:13 ` [PATCH 1/4] ALSA: pxa2xx: fix ac97 cold reset Mike Dunn
2013-01-07 9:16 ` Igor Grinberg
2013-01-07 13:36 ` Mike Dunn
2013-01-07 13:57 ` Igor Grinberg
2013-01-07 14:19 ` Mike Dunn
2013-01-07 15:28 ` Igor Grinberg
2013-01-06 19:13 ` [PATCH 2/4] ALSA: pxa27x: fix ac97 warm reset bug work-around code Mike Dunn
2013-01-07 9:31 ` Igor Grinberg
2013-01-07 11:06 ` Russell King - ARM Linux
2013-01-07 13:40 ` Mike Dunn
2013-01-06 19:13 ` [PATCH 3/4] ALSA: pxa27x: ac97 controller driver requests gpio Mike Dunn
2013-01-07 9:36 ` Igor Grinberg
2013-01-07 9:42 ` Igor Grinberg
2013-01-07 14:10 ` Mike Dunn
2013-01-07 15:38 ` Igor Grinberg
2013-01-07 16:40 ` Mike Dunn
2013-01-06 19:14 ` [PATCH 4/4] ALSA: pxa27x: rename pxa27x_assert_ac97() Mike Dunn
2013-01-07 9:39 ` Igor Grinberg
2013-01-07 14:34 ` Mike Dunn [this message]
2013-01-07 15:41 ` Igor Grinberg
2013-01-06 20:33 ` [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EADCF9.10307@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).