From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n
Date: Wed, 16 Jan 2013 13:17:20 -0600 [thread overview]
Message-ID: <50F6FCC0.6040204@gmail.com> (raw)
In-Reply-To: <1358346726-27199-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 01/16/2013 08:32 AM, Uwe Kleine-K?nig wrote:
> debug_ll_addr is only used on machines with an MMU so it can be #ifdef'ed
> out safely. This fixes:
>
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:104: Error: too many positional arguments
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Olof Johansson <olof@lixom.net>
> ---
> The obvious alternative fix is to make addruart on !MMU take 3
> arguments, too.
We never envision a need to get the uart address from C code on !MMU?
Either way:
Acked-by: Rob Herring <rob.herring@calxeda.com>
>
> The problem was introduced in
>
> e5c5f2a (ARM: implement debug_ll_io_init())
>
> which appeared in v3.8-rc1.
> ---
> arch/arm/kernel/debug.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
> index 6809200..14f7c3b 100644
> --- a/arch/arm/kernel/debug.S
> +++ b/arch/arm/kernel/debug.S
> @@ -100,12 +100,14 @@ ENTRY(printch)
> b 1b
> ENDPROC(printch)
>
> +#ifdef CONFIG_MMU
> ENTRY(debug_ll_addr)
> addruart r2, r3, ip
> str r2, [r0]
> str r3, [r1]
> mov pc, lr
> ENDPROC(debug_ll_addr)
> +#endif
>
> #else
>
>
next prev parent reply other threads:[~2013-01-16 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:32 [PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n Uwe Kleine-König
2013-01-16 17:43 ` Stephen Warren
2013-01-16 19:26 ` Uwe Kleine-König
2013-01-16 19:17 ` Rob Herring [this message]
2013-01-17 8:12 ` Uwe Kleine-König
2013-01-16 22:31 ` Olof Johansson
2013-01-17 16:14 ` Uwe Kleine-König
2013-01-17 22:09 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6FCC0.6040204@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).