From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: arch_timer: Don't expect both secure and nonsecure PPI IRQ info
Date: Fri, 18 Jan 2013 13:13:44 +0000 [thread overview]
Message-ID: <50F94A88.1070209@arm.com> (raw)
In-Reply-To: <1358511830-7909-1-git-send-email-rnayak@ti.com>
On 18/01/13 12:23, Rajendra Nayak wrote:
Hi Rajendra,
> The current logic expects platforms to pass information about *both*
> secure and nonsecure PPI IRQ. Make arch_timer work even when either one
> of those are provided instead.
I'm afraid this patch doesn't really solve the problem. The DT binding
cannot express having only the virtual interrupt, or only the non-secure
physical interrupt. This patch only works in the case where you only
have the secure physical interrupt.
I think the real fix should be to make all the interrupts mandatory in
the DT (they do exist in the HW), and make the code less tolerant of
broken DTs.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2013-01-18 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 12:23 [PATCH] ARM: arch_timer: Don't expect both secure and nonsecure PPI IRQ info Rajendra Nayak
2013-01-18 13:13 ` Marc Zyngier [this message]
2013-01-18 13:28 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F94A88.1070209@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox