From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Mon, 21 Jan 2013 15:18:44 +0200 Subject: [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot In-Reply-To: <1358348462-27693-7-git-send-email-kishon@ti.com> References: <1358348462-27693-1-git-send-email-kishon@ti.com> <1358348462-27693-7-git-send-email-kishon@ti.com> Message-ID: <50FD4034.5040402@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: > The OMAP glue has been modified to get PHY by phandle for dt boot. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/usb/musb/omap2430.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index 3628a50..08709cf 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -346,7 +346,12 @@ static int omap2430_musb_init(struct musb *musb) > * up through ULPI. TWL4030-family PMICs include one, > * which needs a driver, drivers aren't always needed. > */ > - musb->xceiv = devm_usb_get_phy(dev, 0); > + if (dev->parent->of_node) > + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, > + "usb_phy", 0); Why dev->parent and not just dev? > + else > + musb->xceiv = devm_usb_get_phy(dev, 0); > + > if (IS_ERR_OR_NULL(musb->xceiv)) { > pr_err("HS USB OTG: no transceiver configured\n"); > return -ENODEV; > -- cheers, -roger