From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wilson Ding <dingwei@marvell.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Sanghoon Lee <salee@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/4] dt-bindings: cp110: Document the reset controller
Date: Sun, 23 Feb 2025 09:46:22 +0100 [thread overview]
Message-ID: <50acb698-c32c-4276-90d2-46ee9de7bfe9@kernel.org> (raw)
In-Reply-To: <BY3PR18MB4673E3FA63FA85F1C11E68F0A7C62@BY3PR18MB4673.namprd18.prod.outlook.com>
On 22/02/2025 22:02, Wilson Ding wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Friday, February 21, 2025 12:47 AM
>> To: Wilson Ding <dingwei@marvell.com>
>> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; andrew@lunn.ch; gregory.clement@bootlin.com;
>> sebastian.hesselbarth@gmail.com; robh@kernel.org; krzk+dt@kernel.org;
>> conor+dt@kernel.org; p.zabel@pengutronix.de; Sanghoon Lee
>> <salee@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>
>> Subject: [EXTERNAL] Re: [PATCH v2 2/4] dt-bindings: cp110: Document the
>> reset controller
>>
>> On Thu, Feb 20, 2025 at 03: 25: 25PM -0800, Wilson Ding wrote: > Add reset-
>> controller sub-node into the system controller node, and > document the
>> supported reset lines. > > Signed-off-by: Wilson Ding
>> <dingwei@ marvell. com> >
>> On Thu, Feb 20, 2025 at 03:25:25PM -0800, Wilson Ding wrote:
>>> Add reset-controller sub-node into the system controller node, and
>>> document the supported reset lines.
>>>
>>> Signed-off-by: Wilson Ding <dingwei@marvell.com>
>>> ---
>>> .../arm/marvell/cp110-system-controller.txt | 43 +++++++++++++++++++
>>
>> NAK.
>>
>> You already got feedback that TXT bindings are not accepted.
>>
>
> I am not trying to use this TXT for dt-binding. But as you can see this file
> describes all the sub-nodes details, such as mpps, clocks information. So
> that I add the reset line info here. If this is not the right place, where shall
> I put this information. I wonder if you are asking to convert this txt into
> yaml.
You just duplicated the YAML binding in TXT. If you wanted to reference
the child, you would say something that there is a reset device in
binding foo.yaml.
But yeah, ideally this entire binding should be also converted to DT
Schema / YAML.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-23 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 23:25 [PATCH v2 0/4] Add Armada8K reset controller support Wilson Ding
2025-02-20 23:25 ` [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller Wilson Ding
2025-02-21 3:11 ` Rob Herring (Arm)
2025-02-21 8:46 ` Krzysztof Kozlowski
2025-02-21 23:40 ` Rob Herring
2025-02-22 20:57 ` Wilson Ding
2025-02-23 8:48 ` Krzysztof Kozlowski
2025-02-24 18:19 ` Wilson Ding
2025-02-20 23:25 ` [PATCH v2 2/4] dt-bindings: cp110: Document the " Wilson Ding
2025-02-21 8:46 ` Krzysztof Kozlowski
2025-02-22 21:02 ` [EXTERNAL] " Wilson Ding
2025-02-23 8:46 ` Krzysztof Kozlowski [this message]
2025-02-20 23:25 ` [PATCH v2 3/4] reset: Add support for Armada8K " Wilson Ding
2025-02-20 23:25 ` [PATCH v2 4/4] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-21 8:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50acb698-c32c-4276-90d2-46ee9de7bfe9@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=gakula@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=salee@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).