From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CE2AC19F28 for ; Wed, 3 Aug 2022 10:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EFTT5PWOMs/oFT72qCKD7xl0spgqlZhVNv3sbZUziTw=; b=r0Co+U0SbsuPyF jk5Z4wWH2EwIsrByYnTfdlqrDbUrTeDYoX9GyQS6yj11UrN2LCNrTCrj76B8sJ74pskfQ+95nnQwT L89KP6gTp1M7+4NJiC7eieXbvHEHxJmJaRCHqCa/7XagrBiTSapkBBbZAQe9L9ih4IHmC/Q+93BOn ZeeRNaQ87DvSIbKTMSF9fFUGUsHD3WlOYK04k1uzv2ayDY5NNI62GRJr5vTlyg7gXDm+nbSkwavbo CJm4Yaz6iEvE0bN+wTfG8kjwE+V96sjX39C/nCsNgAyJJSD+LonsCZKDz6lCx7zwPuGgdgvS8LXgY CIBd2gI4DLBNsnH7L31Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJBn9-004wfW-N6; Wed, 03 Aug 2022 10:39:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJBe5-004rd8-En for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 10:30:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 360A7113E; Wed, 3 Aug 2022 03:30:30 -0700 (PDT) Received: from [10.57.12.36] (unknown [10.57.12.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4093F3F67D; Wed, 3 Aug 2022 03:30:28 -0700 (PDT) Message-ID: <50d04f45-6aa9-dee8-6647-3f0b909049ea@arm.com> Date: Wed, 3 Aug 2022 11:30:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-bindings: PCI: host-generic-pci: Allow IOMMU and MSI properties Content-Language: en-GB To: Rob Herring Cc: Will Deacon , Bjorn Helgaas , Krzysztof Kozlowski , PCI , linux-arm-kernel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <20220728175137.1172841-1-robh@kernel.org> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_033033_612249_E33CE3CD X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-02 23:21, Rob Herring wrote: > On Tue, Aug 2, 2022 at 3:26 AM Robin Murphy wrote: >> >> On 2022-07-28 18:51, Rob Herring wrote: >>> Allow 'iommu-map', 'iommu-map-mask', and 'msi-parent' properties for >>> generic host. This fixes unevaluated property warnings on Arm Juno, AMD >>> Seattle, and FSL LS1028a. >>> >>> Signed-off-by: Rob Herring >>> --- >>> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> index 6bcaa8f2c3cf..d25423aa7167 100644 >>> --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> @@ -106,6 +106,9 @@ properties: >>> maxItems: 3 >>> >>> dma-coherent: true >>> + iommu-map: true >>> + iommu-map-mask: true >>> + msi-parent: true >> >> Hmm, in general this set looks suspiciously incomplete without msi-map >> and msi-map-mask too. Am I right in thinking that the ideal thing to do >> here would be to convert pci-msi.txt and pci-iommu.txt to schema and >> $ref them? > > I already added msi-map/msi-map-mask to pci-bus.yaml[1] as well as > schemas for iommu-map/iommu-map-mask[2] and msi-parent[3]. Since > msi-map is already in the referenced schema, it is allowed here. > msi-parent is separate because it is used elsewhere. iommu-map is > separate largely to make copying pci-iommu.txt as-is easier. > > And yes, pci-iommu.txt can now be removed. pci-msi.txt is more > complicated as all of it hasn't been moved into schemas. Ah, great! One general comment, though - iommu-map/msi-map have pretty much grown into common IOMMU/MSI consumer properties by now, so IMO they'd be better off living alongside their respective iommus/msi-parent counterparts, so that other consumers like fsl-mc and host1x can reference a common definition rather than duplicating their own. The only aspect that should still belong to the PCI binding is the detail of how PCI B:D:F forms the input ID for the mappings (and equivalently for other bus bindings). Thanks, Robin. > > Rob > > [1] https://github.com/devicetree-org/dt-schema/commit/109bde712466281e8c96a4fadb0f68e7a90a6eca > [2] https://github.com/devicetree-org/dt-schema/commit/3d44bf2b46a9ac638550ca3916d7d7f70823bb58 > [3] https://github.com/devicetree-org/dt-schema/commit/59f2e3103b6e776afe4f42e45897f7eabae06fa4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel