From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A68A2C3DA42 for ; Sun, 14 Jul 2024 13:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hXhsgB5kcttJ8ekP07uZnqVAhfWI+txG6dIDu3n/Ejg=; b=uK0qKGBJyxAyOjtSnZWBTLmw95 G7iDgN9VFZc2Z8oZKSOWKND4oTCH9+YdQ/dzlvryU00/OLvKnwG49FaeC/WsmNKEOZN+ed579S6kU maax6nb582PQhsY5bL0ok9WcKz2YzgM70hr87Z85gIe5y3D8vc8Xw42L6momu/CkToXZluqAuJkVc NjQbk6rRsDFu4y+SYGzQNqyWv3ErFI+0v2SxJ3sG2xrWJpIbR8rFPerLaj/mGdy4XJZnEeG2JOFgH Ev9/evJfKiQY1vtgW7Jp52yFMdOuIpcAvxPz/Ln643Ag1eKTpWunxN3S9WnHhq+BL38akdmDqlkQH zCVd0P/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSzSh-00000004Xel-3T5E; Sun, 14 Jul 2024 13:40:24 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSzSE-00000004XU1-2fxo for linux-arm-kernel@lists.infradead.org; Sun, 14 Jul 2024 13:39:56 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3678f36f154so2008149f8f.2 for ; Sun, 14 Jul 2024 06:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1720964393; x=1721569193; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hXhsgB5kcttJ8ekP07uZnqVAhfWI+txG6dIDu3n/Ejg=; b=hf3Ks024bJvOLDWR/IfgGNGNVtY0uhwQCGPXkm4dLBRLZ+3pF9/U/1M+ec1XaOooSB nlKQvM3/qGANVXgTQ89ICN9VryT2dYTVr6nt68dlR4em8V45YO6HrR1vrjlPcQMhpjw/ rKXJmvtaZvx12lSUiK8nkH6POqyWzhurv6A8W3rRdk/P5c9MV4dP1ldYbkliQq6wMd7d ec8MSjJMlzSbBJsVrruaZqUBs4L9OO5Js1TKOcoURnXqsg8YzJDs8X0jNpU4glXgbdR0 zuHLIrQzN62OT1tT6OyIRxKDLJz8nvp6aBU8iS39KdxvEL+q9mYFatoi8CR4pBOiFVvB DMMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720964393; x=1721569193; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hXhsgB5kcttJ8ekP07uZnqVAhfWI+txG6dIDu3n/Ejg=; b=lAWG5T73UXB06s8eTBD0j1DI3if1agpfmukt0rUgnomDUwflj5BE/hOXNz8r0j6rKV 3Ofbl7rXweY833O9pTrj/m++1zdHMKAnM4MBRBX4FTKNA8hDWezT/a1hVWAfgYs5hH5i 2+GKauHE0TQw4k8DKBsI8viCvUi8sq/gPBgFcc5Qn3FBrDRXRFsNu1m3S5ILZL8Vrq3V W+3s6YjHxAqHmOYMX16XJspUdESiSDEJ1J/AIcw9TaGDTJNdFPNeJ20liZsBNWq8eqr9 Zx3iqGnq9b99MVRyNnqx9IIhdprwxdmjGU+t6CVpj1XXyAYetPpi/cT9RWgdKcX6hkYp PLAA== X-Forwarded-Encrypted: i=1; AJvYcCXv4ZH5IEKx/5FizZVKw9ql1/mR/7ULxBdnj2auKQwZxYw+8DSxCsk0vYlhkMFW52SFttq0xzXQK7lsLyl4nzLpUD5LMPR4b6YTP0j7xKhdC6hYmWk= X-Gm-Message-State: AOJu0YyyVHJQhENVkq9OSWOTaud6QV9eps6D2vIeFjMKKvV2G900IPXh LL0lYMTb5Ot935TlX8W85aO7OmPQnNNwCB6Rp4FwHwAlP2qSrTID1+je3dDe494= X-Google-Smtp-Source: AGHT+IHZ55PvKzpIXyAWZZwdSfOUuHbPyEFib4pjtaWAvo7Wf8TZY7mQZPs6KJ5I7pPxMEqbAjVjCw== X-Received: by 2002:a5d:47a9:0:b0:366:e7e2:13c8 with SMTP id ffacd0b85a97d-367cea46a0bmr13958112f8f.11.1720964392929; Sun, 14 Jul 2024 06:39:52 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dafbea9sm3871306f8f.82.2024.07.14.06.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jul 2024 06:39:52 -0700 (PDT) Message-ID: <50e216ba-6bb1-4794-806e-75a75d778d4b@tuxon.dev> Date: Sun, 14 Jul 2024 16:39:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/27] clk: at91: sama7g5: move mux table macros to header file Content-Language: en-US To: Varshini Rajendran , mturquette@baylibre.com, sboyd@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240703102011.193343-1-varshini.rajendran@microchip.com> <20240703102743.195858-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: <20240703102743.195858-1-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240714_063954_713822_693CF071 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03.07.2024 13:27, Varshini Rajendran wrote: > Move the mux table init and fill macro function definitions from the > sama7g5 pmc driver to the pmc.h header file since they will be used > by other SoC's pmc drivers as well like sam9x7. > > Signed-off-by: Varshini Rajendran Reviewed-by: Claudiu Beznea > --- > drivers/clk/at91/pmc.h | 16 ++++++++++++++++ > drivers/clk/at91/sama7g5.c | 35 ++++++++++------------------------- > 2 files changed, 26 insertions(+), 25 deletions(-) > > diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h > index 91d1c6305d95..4fb29ca111f7 100644 > --- a/drivers/clk/at91/pmc.h > +++ b/drivers/clk/at91/pmc.h > @@ -121,6 +121,22 @@ struct at91_clk_pms { > > #define ndck(a, s) (a[s - 1].id + 1) > #define nck(a) (a[ARRAY_SIZE(a) - 1].id + 1) > + > +#define PMC_INIT_TABLE(_table, _count) \ > + do { \ > + u8 _i; \ > + for (_i = 0; _i < (_count); _i++) \ > + (_table)[_i] = _i; \ > + } while (0) > + > +#define PMC_FILL_TABLE(_to, _from, _count) \ > + do { \ > + u8 _i; \ > + for (_i = 0; _i < (_count); _i++) { \ > + (_to)[_i] = (_from)[_i]; \ > + } \ > + } while (0) > + > struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem, > unsigned int nperiph, unsigned int ngck, > unsigned int npck); > diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c > index e6eb5afba93d..6706d1305baa 100644 > --- a/drivers/clk/at91/sama7g5.c > +++ b/drivers/clk/at91/sama7g5.c > @@ -16,21 +16,6 @@ > > #include "pmc.h" > > -#define SAMA7G5_INIT_TABLE(_table, _count) \ > - do { \ > - u8 _i; \ > - for (_i = 0; _i < (_count); _i++) \ > - (_table)[_i] = _i; \ > - } while (0) > - > -#define SAMA7G5_FILL_TABLE(_to, _from, _count) \ > - do { \ > - u8 _i; \ > - for (_i = 0; _i < (_count); _i++) { \ > - (_to)[_i] = (_from)[_i]; \ > - } \ > - } while (0) > - > static DEFINE_SPINLOCK(pmc_pll_lock); > static DEFINE_SPINLOCK(pmc_mck0_lock); > static DEFINE_SPINLOCK(pmc_mckX_lock); > @@ -1119,17 +1104,17 @@ static void __init sama7g5_pmc_setup(struct device_node *np) > if (!mux_table) > goto err_free; > > - SAMA7G5_INIT_TABLE(mux_table, 3); > - SAMA7G5_FILL_TABLE(&mux_table[3], sama7g5_mckx[i].ep_mux_table, > - sama7g5_mckx[i].ep_count); > + PMC_INIT_TABLE(mux_table, 3); > + PMC_FILL_TABLE(&mux_table[3], sama7g5_mckx[i].ep_mux_table, > + sama7g5_mckx[i].ep_count); > for (j = 0; j < sama7g5_mckx[i].ep_count; j++) { > u8 pll_id = sama7g5_mckx[i].ep[j].pll_id; > u8 pll_compid = sama7g5_mckx[i].ep[j].pll_compid; > > tmp_parent_hws[j] = sama7g5_plls[pll_id][pll_compid].hw; > } > - SAMA7G5_FILL_TABLE(&parent_hws[3], tmp_parent_hws, > - sama7g5_mckx[i].ep_count); > + PMC_FILL_TABLE(&parent_hws[3], tmp_parent_hws, > + sama7g5_mckx[i].ep_count); > > hw = at91_clk_sama7g5_register_master(regmap, sama7g5_mckx[i].n, > num_parents, NULL, parent_hws, mux_table, > @@ -1215,17 +1200,17 @@ static void __init sama7g5_pmc_setup(struct device_node *np) > if (!mux_table) > goto err_free; > > - SAMA7G5_INIT_TABLE(mux_table, 3); > - SAMA7G5_FILL_TABLE(&mux_table[3], sama7g5_gck[i].pp_mux_table, > - sama7g5_gck[i].pp_count); > + PMC_INIT_TABLE(mux_table, 3); > + PMC_FILL_TABLE(&mux_table[3], sama7g5_gck[i].pp_mux_table, > + sama7g5_gck[i].pp_count); > for (j = 0; j < sama7g5_gck[i].pp_count; j++) { > u8 pll_id = sama7g5_gck[i].pp[j].pll_id; > u8 pll_compid = sama7g5_gck[i].pp[j].pll_compid; > > tmp_parent_hws[j] = sama7g5_plls[pll_id][pll_compid].hw; > } > - SAMA7G5_FILL_TABLE(&parent_hws[3], tmp_parent_hws, > - sama7g5_gck[i].pp_count); > + PMC_FILL_TABLE(&parent_hws[3], tmp_parent_hws, > + sama7g5_gck[i].pp_count); > > hw = at91_clk_register_generated(regmap, &pmc_pcr_lock, > &sama7g5_pcr_layout,