linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@microchip.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: atmel: Fix I2C and SPI bus warnings
Date: Fri, 14 Sep 2018 17:20:34 +0200	[thread overview]
Message-ID: <50f3b6db-e892-e614-ccb4-589fcb971827@microchip.com> (raw)
In-Reply-To: <20180913181245.25484-4-robh@kernel.org>

On 13/09/2018 at 20:12, Rob Herring wrote:
> dtc has new checks for I2C and SPI buses. Fix the warnings in node names
> and unit-addresses.
> 
> arch/arm/boot/dts/at91-dvk_som60.dtb: Warning (i2c_bus_reg): /ahb/apb/i2c at f0018000/eeprom at 87: I2C bus unit address format error, expected "57"
> arch/arm/boot/dts/at91-dvk_som60.dtb: Warning (i2c_bus_reg): /ahb/apb/i2c at f0018000/ft5426 at 56: I2C bus unit address format error, expected "38"
> arch/arm/boot/dts/at91-vinco.dtb: Warning (i2c_bus_reg): /ahb/apb/i2c at f8024000/rtc at 64: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/at91sam9260ek.dtb: Warning (spi_bus_reg): /ahb/apb/spi at fffc8000/mtd_dataflash at 0: SPI bus unit address format error, expected "1"
> arch/arm/boot/dts/at91sam9g20ek_2mmc.dtb: Warning (spi_bus_reg): /ahb/apb/spi at fffc8000/mtd_dataflash at 0: SPI bus unit address format error, expected "1"
> arch/arm/boot/dts/at91sam9g20ek.dtb: Warning (spi_bus_reg): /ahb/apb/spi at fffc8000/mtd_dataflash at 0: SPI bus unit address format error, expected "1"
> arch/arm/boot/dts/at91sam9261ek.dtb: Warning (spi_bus_reg): /ahb/apb/spi at fffc8000/tsc2046 at 0: SPI bus unit address format error, expected "2"
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but
> will for 4.20.
> 
>   arch/arm/boot/dts/at91-dvk_su60_somc.dtsi     | 4 ++--
>   arch/arm/boot/dts/at91-dvk_su60_somc_lcm.dtsi | 4 ++--
>   arch/arm/boot/dts/at91-vinco.dts              | 2 +-
>   arch/arm/boot/dts/at91sam9260ek.dts           | 2 +-
>   arch/arm/boot/dts/at91sam9261ek.dts           | 2 +-
>   arch/arm/boot/dts/at91sam9g20ek_common.dtsi   | 2 +-
>   6 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-dvk_su60_somc.dtsi b/arch/arm/boot/dts/at91-dvk_su60_somc.dtsi
> index bb86f17ed5ed..21876da7c442 100644
> --- a/arch/arm/boot/dts/at91-dvk_su60_somc.dtsi
> +++ b/arch/arm/boot/dts/at91-dvk_su60_somc.dtsi
> @@ -70,9 +70,9 @@
>   &i2c1 {
>   	status = "okay";
>   
> -	eeprom at 87 {
> +	eeprom at 57 {
>   		compatible = "giantec,gt24c32a", "atmel,24c32";
> -		reg = <87>;
> +		reg = <0x57>;
>   		pagesize = <32>;
>   	};
>   };
> diff --git a/arch/arm/boot/dts/at91-dvk_su60_somc_lcm.dtsi b/arch/arm/boot/dts/at91-dvk_su60_somc_lcm.dtsi
> index 4b9176dc5d02..df0f0cc575c1 100644
> --- a/arch/arm/boot/dts/at91-dvk_su60_somc_lcm.dtsi
> +++ b/arch/arm/boot/dts/at91-dvk_su60_somc_lcm.dtsi
> @@ -59,9 +59,9 @@
>   &i2c1 {
>   	status = "okay";
>   
> -	ft5426 at 56 {
> +	ft5426 at 38 {
>   		compatible = "focaltech,ft5426", "edt,edt-ft5406";
> -		reg = <56>;
> +		reg = <0x38>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&pinctrl_lcd_ctp_int>;
>   
> diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts
> index 1be9889a2b3a..430277291e02 100644
> --- a/arch/arm/boot/dts/at91-vinco.dts
> +++ b/arch/arm/boot/dts/at91-vinco.dts
> @@ -128,7 +128,7 @@
>   			i2c2: i2c at f8024000 {
>   				status = "okay";
>   
> -				rtc1: rtc at 64 {
> +				rtc1: rtc at 32 {
>   					compatible = "epson,rx8900";
>   					reg = <0x32>;
>   				};
> diff --git a/arch/arm/boot/dts/at91sam9260ek.dts b/arch/arm/boot/dts/at91sam9260ek.dts
> index d2b865f60293..07d1b571e601 100644
> --- a/arch/arm/boot/dts/at91sam9260ek.dts
> +++ b/arch/arm/boot/dts/at91sam9260ek.dts
> @@ -127,7 +127,7 @@
>   
>   			spi0: spi at fffc8000 {
>   				cs-gpios = <0>, <&pioC 11 0>, <0>, <0>;
> -				mtd_dataflash at 0 {
> +				mtd_dataflash at 1 {
>   					compatible = "atmel,at45", "atmel,dataflash";
>   					spi-max-frequency = <50000000>;
>   					reg = <1>;
> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts
> index a29fc0494076..a57f2d435dca 100644
> --- a/arch/arm/boot/dts/at91sam9261ek.dts
> +++ b/arch/arm/boot/dts/at91sam9261ek.dts
> @@ -160,7 +160,7 @@
>   					spi-max-frequency = <15000000>;
>   				};
>   
> -				tsc2046 at 0 {
> +				tsc2046 at 2 {
>   					reg = <2>;
>   					compatible = "ti,ads7843";
>   					interrupts-extended = <&pioC 2 IRQ_TYPE_EDGE_BOTH>;
> diff --git a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> index 71df3adfc7ca..ec1f17ab6753 100644
> --- a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> @@ -109,7 +109,7 @@
>   
>   			spi0: spi at fffc8000 {
>   				cs-gpios = <0>, <&pioC 11 0>, <0>, <0>;
> -				mtd_dataflash at 0 {
> +				mtd_dataflash at 1 {
>   					compatible = "atmel,at45", "atmel,dataflash";
>   					spi-max-frequency = <50000000>;
>   					reg = <1>;
> 


-- 
Nicolas Ferre

  reply	other threads:[~2018-09-14 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 18:12 [PATCH] ARM: dts: atmel: Fix I2C and SPI bus warnings Rob Herring
2018-09-14 15:20 ` Nicolas Ferre [this message]
2018-09-19 17:09 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50f3b6db-e892-e614-ccb4-589fcb971827@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).