* [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
@ 2013-01-24 6:16 Tushar Behera
2013-01-24 6:44 ` Sachin Kamat
2013-01-24 6:51 ` Alim Akhtar
0 siblings, 2 replies; 5+ messages in thread
From: Tushar Behera @ 2013-01-24 6:16 UTC (permalink / raw)
To: linux-arm-kernel
From: Girish K S <ks.giri@samsung.com>
Arndale is a low cost board based on the Samsung Exynos5250 SoC. This
patch adds initial device tree support for this board.
Signed-off-by: Girish K S <ks.giri@samsung.com>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos5250-arndale.dts | 124 ++++++++++++++++++++++++++++++
2 files changed, 125 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5ebb44f..60a9e52 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
exynos4210-trats.dtb \
exynos4412-smdk4412.dtb \
exynos5250-smdk5250.dtb \
+ exynos5250-arndale.dtb \
exynos5250-snow.dtb \
exynos5440-ssdk5440.dtb
dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
new file mode 100644
index 0000000..7504cf3
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -0,0 +1,124 @@
+/*
+ * Samsung's Exynos5250 based Arndale board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos5250.dtsi"
+
+/ {
+ model = "Insignal Arndale evaluation board based on EXYNOS5250";
+ compatible = "insignal,arndale", "samsung,exynos5250";
+
+ memory {
+ reg = <0x40000000 0x80000000>;
+ };
+
+ chosen {
+ bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
+ };
+
+ i2c at 12C60000 {
+ status = "disabled";
+ };
+
+ i2c at 12C70000 {
+ status = "disabled";
+ };
+
+ i2c at 12C80000 {
+ status = "disabled";
+ };
+
+ i2c at 12C90000 {
+ status = "disabled";
+ };
+
+ i2c at 12CA0000 {
+ status = "disabled";
+ };
+
+ i2c at 12CB0000 {
+ status = "disabled";
+ };
+
+ i2c at 12CC0000 {
+ status = "disabled";
+ };
+
+ i2c at 12CD0000 {
+ status = "disabled";
+ };
+
+ i2c at 121D0000 {
+ status = "disabled";
+ };
+
+ dwmmc_0: dwmmc0 at 12200000 {
+ num-slots = <1>;
+ supports-highspeed;
+ broken-cd;
+ fifo-depth = <0x80>;
+ card-detect-delay = <200>;
+ samsung,dw-mshc-ciu-div = <3>;
+ samsung,dw-mshc-sdr-timing = <2 3>;
+ samsung,dw-mshc-ddr-timing = <1 2>;
+
+ slot at 0 {
+ reg = <0>;
+ bus-width = <8>;
+ gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
+ <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>,
+ <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>,
+ <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
+ <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
+ };
+ };
+
+ dwmmc_1: dwmmc1 at 12210000 {
+ status = "disabled";
+ };
+
+ dwmmc_2: dwmmc2 at 12220000 {
+ num-slots = <1>;
+ supports-highspeed;
+ fifo-depth = <0x80>;
+ card-detect-delay = <200>;
+ samsung,dw-mshc-ciu-div = <3>;
+ samsung,dw-mshc-sdr-timing = <2 3>;
+ samsung,dw-mshc-ddr-timing = <1 2>;
+
+ slot at 0 {
+ reg = <0>;
+ bus-width = <4>;
+ samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>;
+ gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>,
+ <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>,
+ <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>,
+ <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>,
+ <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>;
+ };
+ };
+
+ dwmmc_3: dwmmc3 at 12230000 {
+ status = "disabled";
+ };
+
+ spi_0: spi at 12d20000 {
+ status = "disabled";
+ };
+
+ spi_1: spi at 12d30000 {
+ status = "disabled";
+ };
+
+ spi_2: spi at 12d40000 {
+ status = "disabled";
+ };
+};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
2013-01-24 6:16 [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file Tushar Behera
@ 2013-01-24 6:44 ` Sachin Kamat
2013-01-24 9:12 ` Tushar Behera
2013-01-24 6:51 ` Alim Akhtar
1 sibling, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-01-24 6:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tushar,
Just a couple of minor comments.
On 24 January 2013 11:46, Tushar Behera <tushar.behera@linaro.org> wrote:
> From: Girish K S <ks.giri@samsung.com>
>
> Arndale is a low cost board based on the Samsung Exynos5250 SoC. This
> patch adds initial device tree support for this board.
>
> Signed-off-by: Girish K S <ks.giri@samsung.com>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/exynos5250-arndale.dts | 124 ++++++++++++++++++++++++++++++
> 2 files changed, 125 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5ebb44f..60a9e52 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
> exynos4210-trats.dtb \
> exynos4412-smdk4412.dtb \
> exynos5250-smdk5250.dtb \
> + exynos5250-arndale.dtb \
I think this entry could be moved one step up for maintaining
alphabetical order.
> exynos5250-snow.dtb \
> exynos5440-ssdk5440.dtb
> dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> new file mode 100644
> index 0000000..7504cf3
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -0,0 +1,124 @@
> +/*
> + * Samsung's Exynos5250 based Arndale board device tree source
> + *
> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
2013?
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +/include/ "exynos5250.dtsi"
> +
> +/ {
> + model = "Insignal Arndale evaluation board based on EXYNOS5250";
> + compatible = "insignal,arndale", "samsung,exynos5250";
> +
> + memory {
> + reg = <0x40000000 0x80000000>;
> + };
> +
> + chosen {
> + bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
This could be resticted only to console
bootargs = "console=ttySAC2,115200";
> + };
> +
> + i2c at 12C60000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C70000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C80000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C90000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CA0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CB0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CC0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CD0000 {
> + status = "disabled";
> + };
> +
> + i2c at 121D0000 {
> + status = "disabled";
> + };
> +
> + dwmmc_0: dwmmc0 at 12200000 {
> + num-slots = <1>;
> + supports-highspeed;
> + broken-cd;
> + fifo-depth = <0x80>;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3>;
> + samsung,dw-mshc-ddr-timing = <1 2>;
> +
> + slot at 0 {
> + reg = <0>;
> + bus-width = <8>;
> + gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
> + <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>,
> + <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>,
> + <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
> + <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
> + };
> + };
> +
> + dwmmc_1: dwmmc1 at 12210000 {
> + status = "disabled";
> + };
> +
> + dwmmc_2: dwmmc2 at 12220000 {
> + num-slots = <1>;
> + supports-highspeed;
> + fifo-depth = <0x80>;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3>;
> + samsung,dw-mshc-ddr-timing = <1 2>;
> +
> + slot at 0 {
> + reg = <0>;
> + bus-width = <4>;
> + samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>;
> + gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>,
> + <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>,
> + <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>,
> + <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>,
> + <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>;
> + };
> + };
> +
> + dwmmc_3: dwmmc3 at 12230000 {
> + status = "disabled";
> + };
> +
> + spi_0: spi at 12d20000 {
> + status = "disabled";
> + };
> +
> + spi_1: spi at 12d30000 {
> + status = "disabled";
> + };
> +
> + spi_2: spi at 12d40000 {
> + status = "disabled";
> + };
> +};
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
2013-01-24 6:16 [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file Tushar Behera
2013-01-24 6:44 ` Sachin Kamat
@ 2013-01-24 6:51 ` Alim Akhtar
2013-01-24 9:22 ` Tushar Behera
1 sibling, 1 reply; 5+ messages in thread
From: Alim Akhtar @ 2013-01-24 6:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tushar,
On Thu, Jan 24, 2013 at 11:46 AM, Tushar Behera
<tushar.behera@linaro.org> wrote:
> From: Girish K S <ks.giri@samsung.com>
>
> Arndale is a low cost board based on the Samsung Exynos5250 SoC. This
> patch adds initial device tree support for this board.
>
> Signed-off-by: Girish K S <ks.giri@samsung.com>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/exynos5250-arndale.dts | 124 ++++++++++++++++++++++++++++++
> 2 files changed, 125 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5ebb44f..60a9e52 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
> exynos4210-trats.dtb \
> exynos4412-smdk4412.dtb \
> exynos5250-smdk5250.dtb \
> + exynos5250-arndale.dtb \
> exynos5250-snow.dtb \
> exynos5440-ssdk5440.dtb
> dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> new file mode 100644
> index 0000000..7504cf3
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -0,0 +1,124 @@
> +/*
> + * Samsung's Exynos5250 based Arndale board device tree source
> + *
> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +/include/ "exynos5250.dtsi"
> +
> +/ {
> + model = "Insignal Arndale evaluation board based on EXYNOS5250";
> + compatible = "insignal,arndale", "samsung,exynos5250";
> +
> + memory {
> + reg = <0x40000000 0x80000000>;
> + };
> +
> + chosen {
> + bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
> + };
> +
> + i2c at 12C60000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C70000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C80000 {
> + status = "disabled";
> + };
> +
> + i2c at 12C90000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CA0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CB0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CC0000 {
> + status = "disabled";
> + };
> +
> + i2c at 12CD0000 {
> + status = "disabled";
> + };
> +
> + i2c at 121D0000 {
> + status = "disabled";
> + };
> +
Why to disable these i2c devices here? Any particular reason?
You can moves these to exynos5250.dtsi which is suppose to be common
for all the exynos5250 platforms.
Please see the exynos4.dtsi for reference.
> + dwmmc_0: dwmmc0 at 12200000 {
> + num-slots = <1>;
> + supports-highspeed;
> + broken-cd;
> + fifo-depth = <0x80>;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3>;
> + samsung,dw-mshc-ddr-timing = <1 2>;
> +
> + slot at 0 {
> + reg = <0>;
> + bus-width = <8>;
> + gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
> + <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>,
> + <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>,
> + <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
> + <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
> + };
> + };
> +
> + dwmmc_1: dwmmc1 at 12210000 {
> + status = "disabled";
> + };
> +
> + dwmmc_2: dwmmc2 at 12220000 {
> + num-slots = <1>;
> + supports-highspeed;
> + fifo-depth = <0x80>;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3>;
> + samsung,dw-mshc-ddr-timing = <1 2>;
> +
> + slot at 0 {
> + reg = <0>;
> + bus-width = <4>;
> + samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>;
> + gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>,
> + <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>,
> + <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>,
> + <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>,
> + <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>;
> + };
> + };
> +
> + dwmmc_3: dwmmc3 at 12230000 {
> + status = "disabled";
> + };
> +
> + spi_0: spi at 12d20000 {
> + status = "disabled";
> + };
> +
> + spi_1: spi at 12d30000 {
> + status = "disabled";
> + };
> +
> + spi_2: spi at 12d40000 {
> + status = "disabled";
> + };
Same as above.
> +};
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Alim
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
2013-01-24 6:44 ` Sachin Kamat
@ 2013-01-24 9:12 ` Tushar Behera
0 siblings, 0 replies; 5+ messages in thread
From: Tushar Behera @ 2013-01-24 9:12 UTC (permalink / raw)
To: linux-arm-kernel
On 01/24/2013 12:14 PM, Sachin Kamat wrote:
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 5ebb44f..60a9e52 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>> exynos4210-trats.dtb \
>> exynos4412-smdk4412.dtb \
>> exynos5250-smdk5250.dtb \
>> + exynos5250-arndale.dtb \
>
> I think this entry could be moved one step up for maintaining
> alphabetical order.
>
Ok.
>> exynos5250-snow.dtb \
>> exynos5440-ssdk5440.dtb
>> dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>> new file mode 100644
>> index 0000000..7504cf3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -0,0 +1,124 @@
>> +/*
>> + * Samsung's Exynos5250 based Arndale board device tree source
>> + *
>> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
>
> 2013?
>
Ok.
>> + * http://www.samsung.com
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +/include/ "exynos5250.dtsi"
>> +
>> +/ {
>> + model = "Insignal Arndale evaluation board based on EXYNOS5250";
>> + compatible = "insignal,arndale", "samsung,exynos5250";
>> +
>> + memory {
>> + reg = <0x40000000 0x80000000>;
>> + };
>> +
>> + chosen {
>> + bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
>
> This could be resticted only to console
> bootargs = "console=ttySAC2,115200";
>
>
Ok.
I will resubmit the patchset.
--
Tushar Behera
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
2013-01-24 6:51 ` Alim Akhtar
@ 2013-01-24 9:22 ` Tushar Behera
0 siblings, 0 replies; 5+ messages in thread
From: Tushar Behera @ 2013-01-24 9:22 UTC (permalink / raw)
To: linux-arm-kernel
On 01/24/2013 12:21 PM, Alim Akhtar wrote:
>> +
>> + i2c at 12CC0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c at 12CD0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c at 121D0000 {
>> + status = "disabled";
>> + };
>> +
>
> Why to disable these i2c devices here? Any particular reason?
> You can moves these to exynos5250.dtsi which is suppose to be common
> for all the exynos5250 platforms.
> Please see the exynos4.dtsi for reference.
>
Agreed. There was a discussion going on in [1] related to this. Since
there was no consensus on that, I preferred to go with the current
approach that is followed for other EXYNOS5250 based scripts.
If it is agreed by Kukjin to move to Exynos4 style, then I can submit
patches for that.
[1]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg15013.html
--
Tushar Behera
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-24 9:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 6:16 [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file Tushar Behera
2013-01-24 6:44 ` Sachin Kamat
2013-01-24 9:12 ` Tushar Behera
2013-01-24 6:51 ` Alim Akhtar
2013-01-24 9:22 ` Tushar Behera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).