linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds
Date: Thu, 24 Jan 2013 16:42:27 +0100	[thread overview]
Message-ID: <51015663.8080109@epfl.ch> (raw)
In-Reply-To: <5101510C.9050407@ti.com>

Hi Peter,

>>
>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
>> index 89808ce..800be29 100644
>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>> @@ -14,12 +14,13 @@
>>   /include/ "omap3.dtsi"
>>
>>   / {
>> -	leds {
>> -		compatible = "gpio-leds";
>> +	pwmleds {
>> +		compatible = "pwm-leds";
>> +
>>   		overo {
>>   			label = "overo:blue:COM";
>> -			gpios = <&twl_gpio 19 0>;
>> -			linux,default-trigger = "mmc0";
>
> You can keep the default trigger for the pwm-leds as well.
> The best way to test this is on top of linux-next which already have the
> leds-pwm DT bindings.
>

I did it at first, but the led API executes in atomic context, where the 
pwm-twl-led driver uses i2c communication. Setting a trigger will result 
in a kernel panic.

I am working on a patch for pwm-twl-led to defer using a workqueue right 
now.

Cheers,

Florian

  reply	other threads:[~2013-01-24 15:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 17:56 [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support Florian Vaussard
2013-01-23 17:56 ` [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds Florian Vaussard
2013-01-24 15:19   ` Peter Ujfalusi
2013-01-24 15:42     ` Florian Vaussard [this message]
2013-01-24 15:45       ` Peter Ujfalusi
2013-01-24 16:50         ` Florian Vaussard
2013-01-24 17:08           ` Peter Ujfalusi
2013-01-24 21:14             ` Florian Vaussard
2013-01-25  8:29               ` Peter Ujfalusi
2013-01-25 12:07                 ` Peter Ujfalusi
2013-01-25 12:21                   ` Florian Vaussard
2013-01-25 12:30                     ` Peter Ujfalusi
2013-01-23 17:56 ` [PATCH 2/2] ARM: dts: omap3-overo: Add audio support Florian Vaussard
2013-01-24 15:21   ` Peter Ujfalusi
2013-01-24 12:21 ` [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and " Benoit Cousson
2013-02-04  9:14   ` Florian Vaussard
2013-02-06 13:30     ` Benoit Cousson
2013-02-06 14:26       ` Philippe Rétornaz
2013-02-07  7:58       ` Peter Ujfalusi
2013-02-26 16:07         ` Florian Vaussard
2013-02-26 16:19           ` Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51015663.8080109@epfl.ch \
    --to=florian.vaussard@epfl.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).