* OMAP4 randconfig failure: Zynq @ 2013-01-24 11:11 Russell King - ARM Linux 2013-01-24 15:57 ` Josh Cartwright 0 siblings, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2013-01-24 11:11 UTC (permalink / raw) To: linux-arm-kernel The OMAP4 randconfig build last night failed with this error: arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) Full details at the usual place - http://www.arm.linux.org.uk/developer/build/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* OMAP4 randconfig failure: Zynq 2013-01-24 11:11 OMAP4 randconfig failure: Zynq Russell King - ARM Linux @ 2013-01-24 15:57 ` Josh Cartwright 2013-01-24 16:06 ` Russell King - ARM Linux 0 siblings, 1 reply; 6+ messages in thread From: Josh Cartwright @ 2013-01-24 15:57 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: > The OMAP4 randconfig build last night failed with this error: > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > Full details at the usual place - > http://www.arm.linux.org.uk/developer/build/ Curious. This doesn't look like a valid config to me. In particular, both ARCH_MULTIPLATFORM and ARCH_OMAP are selected, even though those selections should be mutually exclusive, since they fall under the same: choice prompt "ARM system type" default ARCH_MULTIPLATFORM Perhaps it's because CONFIG_ARCH_OMAP=y was setup in the seed? oldconfig seems to complain, too: .config:340:warning: override: ARCH_OMAP changes choice state Josh ^ permalink raw reply [flat|nested] 6+ messages in thread
* OMAP4 randconfig failure: Zynq 2013-01-24 15:57 ` Josh Cartwright @ 2013-01-24 16:06 ` Russell King - ARM Linux 2013-01-24 16:12 ` Russell King - ARM Linux 0 siblings, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2013-01-24 16:06 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 24, 2013 at 09:57:04AM -0600, Josh Cartwright wrote: > On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: > > The OMAP4 randconfig build last night failed with this error: > > > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > > > Full details at the usual place - > > http://www.arm.linux.org.uk/developer/build/ > > Curious. This doesn't look like a valid config to me. I think you're wrong. > In particular, both ARCH_MULTIPLATFORM and ARCH_OMAP are selected, even > though those selections should be mutually exclusive, since they fall > under the same: > > choice > prompt "ARM system type" > default ARCH_MULTIPLATFORM > > Perhaps it's because CONFIG_ARCH_OMAP=y was setup in the seed? ARCH_OMAP2PLUS selects ARCH_OMAP, and ARCH_OMAP2PLUS must be enabled to produce a configuration including any OMAP code. > oldconfig seems to complain, too: > > .config:340:warning: override: ARCH_OMAP changes choice state Err, nope, don't get that warning. $ mkdir /tmp/build $ wget -O /tmp/build/.config 'http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=3562' $ emake -j2 O=/tmp/build/ oldconfig GEN /tmp/build/Makefile HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c SHIPPED scripts/kconfig/zconf.hash.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --oldconfig Kconfig # # configuration written to .config # So, the config system produced this configuration, and the config system believes it to be correct. The problem lies elsewhere. Clearly from the error, for a configuration for an OMAP platform to be errored out by a Zynq error, that means there's something that Zynq is missing. ^ permalink raw reply [flat|nested] 6+ messages in thread
* OMAP4 randconfig failure: Zynq 2013-01-24 16:06 ` Russell King - ARM Linux @ 2013-01-24 16:12 ` Russell King - ARM Linux 2013-01-24 17:08 ` Josh Cartwright 0 siblings, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2013-01-24 16:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 24, 2013 at 04:06:09PM +0000, Russell King - ARM Linux wrote: > On Thu, Jan 24, 2013 at 09:57:04AM -0600, Josh Cartwright wrote: > > On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: > > > The OMAP4 randconfig build last night failed with this error: > > > > > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > > > > > Full details at the usual place - > > > http://www.arm.linux.org.uk/developer/build/ > > > > Curious. This doesn't look like a valid config to me. > > I think you're wrong. > > > In particular, both ARCH_MULTIPLATFORM and ARCH_OMAP are selected, even > > though those selections should be mutually exclusive, since they fall > > under the same: > > > > choice > > prompt "ARM system type" > > default ARCH_MULTIPLATFORM > > > > Perhaps it's because CONFIG_ARCH_OMAP=y was setup in the seed? > > ARCH_OMAP2PLUS selects ARCH_OMAP, and ARCH_OMAP2PLUS must be enabled > to produce a configuration including any OMAP code. > > > oldconfig seems to complain, too: > > > > .config:340:warning: override: ARCH_OMAP changes choice state > > Err, nope, don't get that warning. > > $ mkdir /tmp/build > $ wget -O /tmp/build/.config 'http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=3562' > $ emake -j2 O=/tmp/build/ oldconfig > GEN /tmp/build/Makefile > HOSTCC scripts/basic/fixdep > HOSTCC scripts/kconfig/conf.o > SHIPPED scripts/kconfig/zconf.tab.c > SHIPPED scripts/kconfig/zconf.lex.c > SHIPPED scripts/kconfig/zconf.hash.c > HOSTCC scripts/kconfig/zconf.tab.o > HOSTLD scripts/kconfig/conf > scripts/kconfig/conf --oldconfig Kconfig > # > # configuration written to .config > # > > So, the config system produced this configuration, and the config system > believes it to be correct. The problem lies elsewhere. > > Clearly from the error, for a configuration for an OMAP platform to be > errored out by a Zynq error, that means there's something that Zynq is > missing. And what's missing is _specific_ to Zynq. Let's look at the error again: arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) What it means is that the "irqchip_init" identifier was not declared by anything before it has been used. That means arch/arm/mach-zynq/common.c is missing a required #include statement. irqchip_init can be found in linux/irqchip.h. Does arch/arm/mach-zynq/common.c include this required include? No. Therefore, the build fails with the above error. You need to add this include file... ^ permalink raw reply [flat|nested] 6+ messages in thread
* OMAP4 randconfig failure: Zynq 2013-01-24 16:12 ` Russell King - ARM Linux @ 2013-01-24 17:08 ` Josh Cartwright 2013-01-24 17:27 ` Rob Herring 0 siblings, 1 reply; 6+ messages in thread From: Josh Cartwright @ 2013-01-24 17:08 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 24, 2013 at 04:12:11PM +0000, Russell King - ARM Linux wrote: > On Thu, Jan 24, 2013 at 04:06:09PM +0000, Russell King - ARM Linux wrote: > > On Thu, Jan 24, 2013 at 09:57:04AM -0600, Josh Cartwright wrote: > > > On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: > > > > The OMAP4 randconfig build last night failed with this error: > > > > > > > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > > > > > > > Full details at the usual place - > > > > http://www.arm.linux.org.uk/developer/build/ > > > > > > Curious. This doesn't look like a valid config to me. > > > > I think you're wrong. Yes, indeed. I was running my tests using the wrong tree. I can see this issue in today's linux-next. Sorry for the noise. [..] > > And what's missing is _specific_ to Zynq. Let's look at the error again: > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > What it means is that the "irqchip_init" identifier was not declared by > anything before it has been used. That means arch/arm/mach-zynq/common.c > is missing a required #include statement. > > irqchip_init can be found in linux/irqchip.h. Does arch/arm/mach-zynq/common.c > include this required include? No. Therefore, the build fails with the > above error. > > You need to add this include file... Agreed, thanks. Looks like this was introduced with "ARM: use common irqchip_init for GIC init". Here's a patch to fix it up, it probably makes sense to be pulled into Rob's irqchip/gic-vic-move branch. -- 8< -- Subject: [PATCH] ARM: zynq: include irqchip.h to prevent build failure Commit 0529e315bbda5d502c93df2cfafba9bb337fbdf4 ("ARM: use common irqchip_init for GIC init") converts Zynq to make use of irqchip_init, but fails to include linux/irqchip.h. Fixes this build error: arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) Reported-by: Russell King <linux@arm.linux.org.uk> Cc: Rob Herring <rob.herring@calxeda.com> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com> --- arch/arm/mach-zynq/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index 8513b16..8a0b8ab 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -20,6 +20,7 @@ #include <linux/platform_device.h> #include <linux/clk.h> #include <linux/clk/zynq.h> +#include <linux/irqchip.h> #include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/of_platform.h> -- 1.8.1.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* OMAP4 randconfig failure: Zynq 2013-01-24 17:08 ` Josh Cartwright @ 2013-01-24 17:27 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2013-01-24 17:27 UTC (permalink / raw) To: linux-arm-kernel On 01/24/2013 11:08 AM, Josh Cartwright wrote: > On Thu, Jan 24, 2013 at 04:12:11PM +0000, Russell King - ARM Linux wrote: >> On Thu, Jan 24, 2013 at 04:06:09PM +0000, Russell King - ARM Linux wrote: >>> On Thu, Jan 24, 2013 at 09:57:04AM -0600, Josh Cartwright wrote: >>>> On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: >>>>> The OMAP4 randconfig build last night failed with this error: >>>>> >>>>> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) >>>>> >>>>> Full details at the usual place - >>>>> http://www.arm.linux.org.uk/developer/build/ >>>> >>>> Curious. This doesn't look like a valid config to me. >>> >>> I think you're wrong. > > Yes, indeed. I was running my tests using the wrong tree. I can see > this issue in today's linux-next. Sorry for the noise. > > [..] >> >> And what's missing is _specific_ to Zynq. Let's look at the error again: >> >> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) >> >> What it means is that the "irqchip_init" identifier was not declared by >> anything before it has been used. That means arch/arm/mach-zynq/common.c >> is missing a required #include statement. >> >> irqchip_init can be found in linux/irqchip.h. Does arch/arm/mach-zynq/common.c >> include this required include? No. Therefore, the build fails with the >> above error. >> >> You need to add this include file... > > Agreed, thanks. Looks like this was introduced with "ARM: use common > irqchip_init for GIC init". Here's a patch to fix it up, it probably > makes sense to be pulled into Rob's irqchip/gic-vic-move branch. Can you also add zynq to multi_v7_defconfig if that is not already queued up. Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-24 17:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-24 11:11 OMAP4 randconfig failure: Zynq Russell King - ARM Linux 2013-01-24 15:57 ` Josh Cartwright 2013-01-24 16:06 ` Russell King - ARM Linux 2013-01-24 16:12 ` Russell King - ARM Linux 2013-01-24 17:08 ` Josh Cartwright 2013-01-24 17:27 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).