* [PATCH 0/2] ARM: davinci: da850: add ethernet driver DT support
@ 2013-01-21 6:29 Prabhakar Lad
2013-01-21 6:29 ` [PATCH 1/2] ARM: davinci: da850: add DT node for eth0 Prabhakar Lad
2013-01-21 6:29 ` [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry " Prabhakar Lad
0 siblings, 2 replies; 5+ messages in thread
From: Prabhakar Lad @ 2013-01-21 6:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Lad, Prabhakar <prabhakar.lad@ti.com>
This patch set enables Ethernet support through device tree model.
Patches are available on [1] for testing.
[1] http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/da850_dt
Lad, Prabhakar (2):
ARM: davinci: da850: add DT node for eth0.
ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.
arch/arm/boot/dts/da850-evm.dts | 3 +++
arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++
arch/arm/mach-davinci/da8xx-dt.c | 9 ++++++++-
3 files changed, 26 insertions(+), 1 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: davinci: da850: add DT node for eth0.
2013-01-21 6:29 [PATCH 0/2] ARM: davinci: da850: add ethernet driver DT support Prabhakar Lad
@ 2013-01-21 6:29 ` Prabhakar Lad
2013-01-25 6:23 ` Sekhar Nori
2013-01-21 6:29 ` [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry " Prabhakar Lad
1 sibling, 1 reply; 5+ messages in thread
From: Prabhakar Lad @ 2013-01-21 6:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Lad, Prabhakar <prabhakar.lad@ti.com>
Add eth0 device tree node information to da850 by
providing interrupt details and local mac address of eth0.
Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: netdev at vger.kernel.org
Cc: devicetree-discuss at lists.ozlabs.org
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Heiko Schocher <hs@denx.de>
---
arch/arm/boot/dts/da850-evm.dts | 3 +++
arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 37dc5a3..a1d6e3e 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -24,5 +24,8 @@
serial2: serial at 1d0d000 {
status = "okay";
};
+ eth0: emac at 1e20000 {
+ status = "okay";
+ };
};
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 640ab75..309cc99 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -56,5 +56,20 @@
interrupt-parent = <&intc>;
status = "disabled";
};
+ eth0: emac at 1e20000 {
+ compatible = "ti,davinci-dm6467-emac";
+ reg = <0x220000 0x4000>;
+ ti,davinci-ctrl-reg-offset = <0x3000>;
+ ti,davinci-ctrl-mod-reg-offset = <0x2000>;
+ ti,davinci-ctrl-ram-offset = <0>;
+ ti,davinci-ctrl-ram-size = <0x2000>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ interrupts = <33
+ 34
+ 35
+ 36
+ >;
+ interrupt-parent = <&intc>;
+ };
};
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.
2013-01-21 6:29 [PATCH 0/2] ARM: davinci: da850: add ethernet driver DT support Prabhakar Lad
2013-01-21 6:29 ` [PATCH 1/2] ARM: davinci: da850: add DT node for eth0 Prabhakar Lad
@ 2013-01-21 6:29 ` Prabhakar Lad
2013-01-25 6:25 ` Sekhar Nori
1 sibling, 1 reply; 5+ messages in thread
From: Prabhakar Lad @ 2013-01-21 6:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Lad, Prabhakar <prabhakar.lad@ti.com>
Add OF_DEV_AUXDATA for eth0 driver in da850 board dt
file to use emac clock.
Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: netdev at vger.kernel.org
Cc: devicetree-discuss at lists.ozlabs.org
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Heiko Schocher <hs@denx.de>
---
arch/arm/mach-davinci/da8xx-dt.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
index 37c27af..d548a38 100644
--- a/arch/arm/mach-davinci/da8xx-dt.c
+++ b/arch/arm/mach-davinci/da8xx-dt.c
@@ -37,11 +37,18 @@ static void __init da8xx_init_irq(void)
of_irq_init(da8xx_irq_match);
}
+struct of_dev_auxdata da850_evm_auxdata_lookup[] __initdata = {
+ OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e20000, "davinci_emac.1",
+ NULL),
+ {}
+};
+
#ifdef CONFIG_ARCH_DAVINCI_DA850
static void __init da850_init_machine(void)
{
- of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+ of_platform_populate(NULL, of_default_bus_match_table,
+ da850_evm_auxdata_lookup, NULL);
da8xx_uart_clk_enable();
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: davinci: da850: add DT node for eth0.
2013-01-21 6:29 ` [PATCH 1/2] ARM: davinci: da850: add DT node for eth0 Prabhakar Lad
@ 2013-01-25 6:23 ` Sekhar Nori
0 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2013-01-25 6:23 UTC (permalink / raw)
To: linux-arm-kernel
Prabhakar,
On 1/21/2013 11:59 AM, Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>
> Add eth0 device tree node information to da850 by
> providing interrupt details and local mac address of eth0.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: netdev at vger.kernel.org
> Cc: devicetree-discuss at lists.ozlabs.org
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> arch/arm/boot/dts/da850-evm.dts | 3 +++
> arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++
Can you rebase this to apply to v3.9/dt branch of my tree?
> 2 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 37dc5a3..a1d6e3e 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -24,5 +24,8 @@
> serial2: serial at 1d0d000 {
> status = "okay";
> };
> + eth0: emac at 1e20000 {
> + status = "okay";
> + };
> };
> };
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 640ab75..309cc99 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -56,5 +56,20 @@
> interrupt-parent = <&intc>;
> status = "disabled";
> };
> + eth0: emac at 1e20000 {
> + compatible = "ti,davinci-dm6467-emac";
> + reg = <0x220000 0x4000>;
> + ti,davinci-ctrl-reg-offset = <0x3000>;
> + ti,davinci-ctrl-mod-reg-offset = <0x2000>;
> + ti,davinci-ctrl-ram-offset = <0>;
> + ti,davinci-ctrl-ram-size = <0x2000>;
> + local-mac-address = [ 00 00 00 00 00 00 ];
> + interrupts = <33
> + 34
> + 35
> + 36
> + >;
> + interrupt-parent = <&intc>;
instead of setting interrupt-parent for each node, this can be done once
for soc and child nodes should inherit this property. This needs to be
fixed for existing serial nodes too.
Also, can you take care of pinmux too? we should not be relying on
u-boot to setup the pinmux for us.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.
2013-01-21 6:29 ` [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry " Prabhakar Lad
@ 2013-01-25 6:25 ` Sekhar Nori
0 siblings, 0 replies; 5+ messages in thread
From: Sekhar Nori @ 2013-01-25 6:25 UTC (permalink / raw)
To: linux-arm-kernel
On 1/21/2013 11:59 AM, Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>
> Add OF_DEV_AUXDATA for eth0 driver in da850 board dt
> file to use emac clock.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: netdev at vger.kernel.org
> Cc: devicetree-discuss at lists.ozlabs.org
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> arch/arm/mach-davinci/da8xx-dt.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
> index 37c27af..d548a38 100644
> --- a/arch/arm/mach-davinci/da8xx-dt.c
> +++ b/arch/arm/mach-davinci/da8xx-dt.c
> @@ -37,11 +37,18 @@ static void __init da8xx_init_irq(void)
> of_irq_init(da8xx_irq_match);
> }
>
> +struct of_dev_auxdata da850_evm_auxdata_lookup[] __initdata = {
This is specific to da850 and not da850_evm so it should be named so.
You can call it da8xx_auxdata keeping with the file naming.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-25 6:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-21 6:29 [PATCH 0/2] ARM: davinci: da850: add ethernet driver DT support Prabhakar Lad
2013-01-21 6:29 ` [PATCH 1/2] ARM: davinci: da850: add DT node for eth0 Prabhakar Lad
2013-01-25 6:23 ` Sekhar Nori
2013-01-21 6:29 ` [PATCH 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry " Prabhakar Lad
2013-01-25 6:25 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).