From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Sat, 26 Jan 2013 13:50:11 +0100 Subject: [PATCH V3 8/8] ARM: kirkwood: mv643xx_eth dt conversion In-Reply-To: <20130126123827.GA5786@lunn.ch> References: <20130126123827.GA5786@lunn.ch> Message-ID: <5103D103.5040409@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/26/2013 01:38 PM, Andrew Lunn wrote: >> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c >> index 73b76e4..7ab92e5 100644 >> --- a/arch/arm/mach-kirkwood/board-dt.c >> +++ b/arch/arm/mach-kirkwood/board-dt.c >> @@ -48,7 +48,7 @@ static void __init kirkwood_legacy_clk_init(void) >> clkspec.args_count = 1; >> >> clkspec.args[0] = CGC_BIT_GE0; >> - orion_clkdev_add(NULL, "mv643xx_eth_port.0", >> + orion_clkdev_add(NULL, "f1072000.egiga0", >> of_clk_get_from_provider(&clkspec)); >> >> clkspec.args[0] = CGC_BIT_PEX0; >> @@ -60,7 +60,7 @@ static void __init kirkwood_legacy_clk_init(void) >> of_clk_get_from_provider(&clkspec)); >> >> clkspec.args[0] = CGC_BIT_GE1; >> - orion_clkdev_add(NULL, "mv643xx_eth_port.1", >> + orion_clkdev_add(NULL, "f1076000.egiga1", >> of_clk_get_from_provider(&clkspec)); >> } >> > These changes break any platform not yet converted, eg my QNAP box now > locks up solid. > > Something is not right here, or i'm not understanding something. DT > devices should not need code like this, only devices not yet using > DT.... Jason, Andrew, have a look at dove_legacy_clk_init() in arch/arm/mach-dove/common.c. This is how I handled non-DT clock aliases from DT provided clocks. Maybe you can also use it for kirkwood. Sebastian