* [PATCH] arm: zynq: Add missing irqchip.h to common.c
@ 2013-01-28 12:30 Michal Simek
2013-01-28 14:17 ` Rob Herring
2013-01-29 18:58 ` Olof Johansson
0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2013-01-28 12:30 UTC (permalink / raw)
To: linux-arm-kernel
The patch: "ARM: use common irqchip_init for GIC init"
(sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4)
should also add linux/irqchip.h header.
Error message:
arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
undeclared here (not in a function)
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
arch/arm/mach-zynq/common.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
index 6472a69..cf3ec54 100644
--- a/arch/arm/mach-zynq/common.c
+++ b/arch/arm/mach-zynq/common.c
@@ -24,6 +24,7 @@
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/of.h>
+#include <linux/irqchip.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm: zynq: Add missing irqchip.h to common.c
2013-01-28 12:30 [PATCH] arm: zynq: Add missing irqchip.h to common.c Michal Simek
@ 2013-01-28 14:17 ` Rob Herring
2013-01-28 14:28 ` Michal Simek
2013-01-29 18:58 ` Olof Johansson
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2013-01-28 14:17 UTC (permalink / raw)
To: linux-arm-kernel
On 01/28/2013 06:30 AM, Michal Simek wrote:
> The patch: "ARM: use common irqchip_init for GIC init"
> (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4)
> should also add linux/irqchip.h header.
>
> Error message:
> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
> undeclared here (not in a function)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
FYI, there's already a patch posted for this:
http://www.spinics.net/lists/arm-kernel/msg219556.html
Rob
> ---
> arch/arm/mach-zynq/common.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
> index 6472a69..cf3ec54 100644
> --- a/arch/arm/mach-zynq/common.c
> +++ b/arch/arm/mach-zynq/common.c
> @@ -24,6 +24,7 @@
> #include <linux/of_irq.h>
> #include <linux/of_platform.h>
> #include <linux/of.h>
> +#include <linux/irqchip.h>
>
> #include <asm/mach/arch.h>
> #include <asm/mach/map.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: zynq: Add missing irqchip.h to common.c
2013-01-28 14:17 ` Rob Herring
@ 2013-01-28 14:28 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2013-01-28 14:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob,
2013/1/28 Rob Herring <robherring2@gmail.com>:
> On 01/28/2013 06:30 AM, Michal Simek wrote:
>> The patch: "ARM: use common irqchip_init for GIC init"
>> (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4)
>> should also add linux/irqchip.h header.
>>
>> Error message:
>> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
>> undeclared here (not in a function)
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
> FYI, there's already a patch posted for this:
>
> http://www.spinics.net/lists/arm-kernel/msg219556.html
Interesting that I am completely ignored in CC.
Anyway updated maintainer fragment hopefully resolve this.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: zynq: Add missing irqchip.h to common.c
2013-01-28 12:30 [PATCH] arm: zynq: Add missing irqchip.h to common.c Michal Simek
2013-01-28 14:17 ` Rob Herring
@ 2013-01-29 18:58 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2013-01-29 18:58 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 28, 2013 at 01:30:50PM +0100, Michal Simek wrote:
> The patch: "ARM: use common irqchip_init for GIC init"
> (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4)
> should also add linux/irqchip.h header.
>
> Error message:
> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
> undeclared here (not in a function)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-29 18:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-28 12:30 [PATCH] arm: zynq: Add missing irqchip.h to common.c Michal Simek
2013-01-28 14:17 ` Rob Herring
2013-01-28 14:28 ` Michal Simek
2013-01-29 18:58 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox