linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: xi.wang@gmail.com (Xi Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: ixp4xx eth broken in 3.7.0/3.8-rc5?
Date: Tue, 29 Jan 2013 19:32:23 -0500	[thread overview]
Message-ID: <51086A17.1090707@gmail.com> (raw)
In-Reply-To: <20744.25884.660535.514911@pilspetsen.it.uu.se>

On 1/29/13 7:11 PM, Mikael Pettersson wrote:
> A git bisect identified the following as the culprit:
> 
>   > From 1a4901177574083c35fafc24c4d151c2a7c7647c Mon Sep 17 00:00:00 2001
>   > From: Xi Wang <xi.wang@gmail.com>
>   > Date: Sat, 17 Nov 2012 20:25:09 +0000
>   > Subject: [PATCH] ixp4xx_eth: avoid calling dma_pool_create() with NULL dev
>   >
>   > Use &port->netdev->dev instead of NULL since dma_pool_create() doesn't
>   > allow NULL dev.
>   >
>   > Signed-off-by: Xi Wang <xi.wang@gmail.com>
>   > Cc: Andrew Morton <akpm@linux-foundation.org>
>   > Signed-off-by: David S. Miller <davem@davemloft.net>
>   > ---
>   >  drivers/net/ethernet/xscale/ixp4xx_eth.c |    8 +++++---
>   >  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> Reverting this unbreaks ixp4xx_eth on my ixp4xx machine with kernels
> 3.7.0 and 3.8-rc5.

Thanks.  The problem was that in init_queues(), the dma_pool_create()
call requires a non-null dev.

  dma_pool = dma_pool_create(DRV_NAME, ??, ...);

What do you think would work here?

  reply	other threads:[~2013-01-30  0:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 19:42 ixp4xx eth broken in 3.7.0/3.8-rc5? Mikael Pettersson
2013-01-30  0:11 ` Mikael Pettersson
2013-01-30  0:32   ` Xi Wang [this message]
2013-01-30  1:34     ` Ben Hutchings
2013-01-30 10:11       ` Mikael Pettersson
2013-01-30 20:50         ` Mikael Pettersson
2013-01-31 21:54   ` Krzysztof Halasa
2013-02-10 19:06 ` Krzysztof Halasa
     [not found]   ` <m3a9r2d5md.fsf_-_@intrepid.localdomain>
2013-02-18  9:08     ` ARM coherent allocs, Was: " Mikael Pettersson
2013-02-18  9:59       ` Russell King - ARM Linux
2013-02-18 20:30       ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51086A17.1090707@gmail.com \
    --to=xi.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).