From: kishon@ti.com (kishon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type
Date: Thu, 31 Jan 2013 15:00:55 +0530 [thread overview]
Message-ID: <510A39CF.7020403@ti.com> (raw)
In-Reply-To: <20130131092805.GB24675@pengutronix.de>
On Thursday 31 January 2013 02:58 PM, Sascha Hauer wrote:
> On Thu, Jan 31, 2013 at 02:42:48PM +0530, kishon wrote:
>> Hi,
>>
>> On Thursday 31 January 2013 02:31 PM, Sascha Hauer wrote:
>>> From: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>>
>>> This adds two little devicetree helper functions for determining the
>>> dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from
>>> the devicetree.
>>>
>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>>> ---
>>> drivers/usb/phy/Makefile | 1 +
>>> drivers/usb/phy/phy.c | 10 ++++++++++
>>> drivers/usb/usb-common.c | 36 ++++++++++++++++++++++++++++++++++++
>>> include/linux/usb/of.h | 27 +++++++++++++++++++++++++++
>>> include/linux/usb/otg.h | 7 +++++++
>>> include/linux/usb/phy.h | 9 +++++++++
>>> 6 files changed, 90 insertions(+)
>>> create mode 100644 include/linux/usb/of.h
>>>
>>> diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
>>> index 9fa6327..e1be1e8 100644
>>> --- a/drivers/usb/phy/Makefile
>>> +++ b/drivers/usb/phy/Makefile
>>> @@ -5,6 +5,7 @@
>>> ccflags-$(CONFIG_USB_DEBUG) := -DDEBUG
>>>
>>> obj-$(CONFIG_USB_OTG_UTILS) += phy.o
>>> +obj-$(CONFIG_OF) += of.o
>>
>> You've missed doing "git add ..usb/phy/of.c".
>>
>>> obj-$(CONFIG_OMAP_USB2) += omap-usb2.o
>>> obj-$(CONFIG_OMAP_USB3) += omap-usb3.o
>>> obj-$(CONFIG_OMAP_CONTROL_USB) += omap-control-usb.o
>>> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
>>> index ef35eb0..3ad4b5c 100644
>>> --- a/drivers/usb/phy/phy.c
>>> +++ b/drivers/usb/phy/phy.c
>>> @@ -1,3 +1,13 @@
>>> +/*
>>> + * phy.c -- USB phy handling
>>> + *
>>> + * Copyright (C) 2004 Texas Instruments
>>
>> it's 2013 already :-P
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>
>> But your *MODULE_LICENSE("GPL")* below tells it's only GPL.
>
> The MODULE_LICENSE("GPL") is in usb-common.c, not in the file I added.
huh.. just noticed. sorry for the noise.
Thanks
Kishon
next prev parent reply other threads:[~2013-01-31 9:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 9:01 [PATCH v2] Add USB of helpers and use them in the chipidea driver Sascha Hauer
2013-01-31 9:01 ` [PATCH 1/6] USB: move bulk of otg/otg.c to phy/phy.c Sascha Hauer
2013-01-31 9:16 ` kishon
2013-01-31 9:01 ` [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-31 9:12 ` kishon
2013-01-31 9:28 ` Sascha Hauer
2013-01-31 9:30 ` kishon [this message]
2013-01-31 9:20 ` Greg KH
2013-01-31 9:26 ` Sascha Hauer
2013-01-31 10:01 ` Peter Chen
2013-01-31 10:12 ` Sascha Hauer
2013-01-31 9:01 ` [PATCH 3/6] USB: chipidea: ci13xxx-imx: create dynamic platformdata Sascha Hauer
2013-01-31 9:44 ` Peter Chen
2013-01-31 9:01 ` [PATCH 4/6] USB: chipidea: add PTW and PTS handling Sascha Hauer
2013-01-31 9:46 ` Peter Chen
2013-01-31 9:01 ` [PATCH 5/6] USB chipidea: introduce dual role mode pdata flags Sascha Hauer
2013-01-31 9:01 ` [PATCH 6/6] USB chipidea i.MX: introduce dr_mode property Sascha Hauer
2013-01-31 9:47 ` Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2013-01-30 15:29 [PATCH] Add USB of helpers and use them in the chipidea driver Sascha Hauer
2013-01-30 15:29 ` [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-31 2:30 ` Peter Chen
2013-01-31 8:05 ` Sascha Hauer
2013-01-31 6:14 ` kishon
2013-01-31 7:43 ` Sascha Hauer
2013-01-31 8:17 ` kishon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A39CF.7020403@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).