From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly
Date: Thu, 31 Jan 2013 15:47:20 +0530 [thread overview]
Message-ID: <510A44B0.30200@ti.com> (raw)
In-Reply-To: <EF466712-C5FF-4A91-BDF3-477559B02705@dominion.thruhere.net>
On 1/31/2013 1:33 AM, Koen Kooi wrote:
> Op 30 jan. 2013, om 20:56 heeft Mugunthan V N <mugunthanvnm@ti.com> het volgende geschreven:
>
>> CPDMA interrupts are not properly acknowledged which leads to interrupt
>> storm, only cpdma interrupt 0 is acknowledged in Davinci CPDMA driver.
>> Changed cpdma_ctlr_eoi api to acknowledge 1 and 2 interrupts which are
>> used for rx and tx respectively.
> A brief inspection shows that this still isn't following the TRM, but Pantelis' patch does. Can you please fix this driver to follow the TRM and make it work on both PG1.0 and PG2.0 instead of papering over bugs instead of fixing them properly?
Existing driver implementation is also complies with TRM. What Pantelis
added
additionally are non-napi implementation, handled cpdma processed tx and rx
processing separately and renamed wr_reg as per TRM naming convention..
Also he
has added a dummy reading tx/rx stat which is mentioned in TRM, but this
stat
is required only when using multichannel for data transfer. Current
implementation
of CPSW driver uses only channel 0 of Tx and Rx channels respectively
for transmission
and reading stat doesn't gets any effect in interrupt acknowledgment.
Since both tx and rx are processed in same napi api, so i have added
interrupt
acknowledgment to the same existing api.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-01-31 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 19:56 [PATCH 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly Mugunthan V N
2013-01-30 20:03 ` Koen Kooi
2013-01-31 10:17 ` Mugunthan V N [this message]
2013-01-31 11:22 ` Pantelis Antoniou
2013-01-31 14:00 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A44B0.30200@ti.com \
--to=mugunthanvnm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).