From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mtd: gpmi: set the Golois Field bit for mx6q's BCH
Date: Mon, 4 Feb 2013 17:11:37 +0800 [thread overview]
Message-ID: <510F7B49.3010809@freescale.com> (raw)
In-Reply-To: <1359966688.13791.16.camel@sauron.fi.intel.com>
? 2013?02?04? 16:31, Artem Bityutskiy ??:
> On Fri, 2013-01-25 at 14:04 +0800, Huang Shijie wrote:
>> +#define BF_BCH_FLASH0LAYOUT0_GF(v, x) \
>> + ((GPMI_IS_MX6Q(x)&& ((v) == 14)) \
>> + ? (((1)<< MX6Q_BP_BCH_FLASH0LAYOUT0_GF_13_14) \
>> + & MX6Q_BM_BCH_FLASH0LAYOUT0_GF_13_14) \
>> + : 0 \
>> + )
> Did you consider using static inline functions instead of macro
These macros are only used when the different archs have different
definitions about
the some registers. Yes, it's ok to use the functions to replace them.
I am not sure if there is still a need to add the similar macros, if it
does, i can change to use
the inline functions.
thanks
Huang Shijie
prev parent reply other threads:[~2013-02-04 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 6:04 [PATCH 1/2] mtd: gpmi: set the Golois Field bit for mx6q's BCH Huang Shijie
2013-01-25 6:04 ` [PATCH 2/2] mtd: gpmi: add sanity check for the ECC strength Huang Shijie
2013-01-29 1:23 ` [PATCH v2] mtd: gpmi: add sanity check for the ECC Huang Shijie
2013-02-04 8:31 ` [PATCH 1/2] mtd: gpmi: set the Golois Field bit for mx6q's BCH Artem Bityutskiy
2013-02-04 9:11 ` Huang Shijie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510F7B49.3010809@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).