From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.dooks@codethink.co.uk (Ben Dooks) Date: Mon, 11 Feb 2013 18:45:19 +0000 Subject: [PATCH 0/8] usb: ehci: more bus glues as separate modules In-Reply-To: <5117edda.860e440a.097c.3507@mx.google.com> References: <5117edda.860e440a.097c.3507@mx.google.com> Message-ID: <51193C3F.6000908@codethink.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/02/13 18:58, manjunath.goudar at linaro.org wrote: > From: Manjunath Goudar > > Separate the SOC On-Chip host controller driver from ehci-hcd > host code into its own driver module > > Manjunath Goudar (8): > USB: EHCI: make ehci-spear a separate driver > USB: EHCI: make ehci-atmel a separate driver > USB: EHCI: make ehci-s5p a separate driver > USB: EHCI: make ehci-mv a separate driver > USB: EHCI: make ehci-vt8500 a separate driver > USB: EHCI: make ehci-msm a separate driver > USB: EHCI: make ehci-w90X900 a separate driver > USB: EHCI: make ehci-orion a separate driver > > drivers/usb/host/Kconfig | 42 +++++++++++-- > drivers/usb/host/Makefile | 9 ++- > drivers/usb/host/ehci-atmel.c | 77 ++++++++++++----------- > drivers/usb/host/ehci-hcd.c | 52 +++------------- > drivers/usb/host/ehci-msm.c | 85 +++++++++++-------------- > drivers/usb/host/ehci-mv.c | 80 +++++++++++------------- > drivers/usb/host/ehci-orion.c | 91 +++++++++++++-------------- > drivers/usb/host/ehci-s5p.c | 69 ++++++++++++--------- > drivers/usb/host/ehci-spear.c | 131 ++++++++++++++++++++------------------- > drivers/usb/host/ehci-vt8500.c | 73 ++++++++++------------ > drivers/usb/host/ehci-w90x900.c | 90 ++++++++++++--------------- > drivers/usb/host/ehci.h | 2 +- > 12 files changed, 392 insertions(+), 409 deletions(-) Having looked at this, we will end up with a number of modules, each having very similar code in them.# How about we add drivers/usb/host/ehci-platform.c for all the platform based drivers. I think it is possible to remove all the specific names, as we certainly don't need the driver advertising itself for each system. Also, does anyone rely on the name field in the HC info, or can it just be "Platform EHCI" ? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius