* [PATCH V3 1/2] get_maintainer: allow keywords to match filenames
@ 2013-02-11 23:40 Stephen Warren
2013-02-11 23:40 ` [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
2013-02-12 0:00 ` [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Joe Perches
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Warren @ 2013-02-11 23:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Stephen Warren <swarren@nvidia.com>
Allow K: entries in MAINTAINERS to match directly against filenames;
either those extracted from patch +++ or --- lines, or those specified
on the command-line using the -f option.
This potentially allows fewer lines in a MAINTAINERS entry, if all the
relevant files are scattered throughout the whole kernel tree, yet
contain some common keyword. An example would be using an ARM SoC name
as the keyword to catch all related drivers.
I don't think setting exact_pattern_match_hash would be appropriate here;
at least for intended Tegra use case, this feature is to ensure that all
Tegra-related driver changes get Cc'd to the Tegra mailing list. Setting
exact_pattern_match_hash would prevent git history parsing for e.g. S-o-b
tags, which still seems like it would be useful. Hence, this flag isn't
set.
The value in $hash{$tvi} doesn't seem relevant, so I just assign 0.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
V3: New patch.
Joe, I'm not sure if you care where this gets merged; could it go through
arm-soc together with patch 2/2? A quick look at git history of the
script in linux-next indicates there won't be conflicts doing that.
scripts/get_maintainer.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 18d4ab5..96cf92a 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -611,6 +611,10 @@ sub get_maintainers {
$hash{$tvi} = $value_pd;
}
}
+ } elsif ($type eq "K") {
+ if ($file =~ m/$value/x) {
+ $hash{$tvi} = 0;
+ }
}
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files
2013-02-11 23:40 [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
@ 2013-02-11 23:40 ` Stephen Warren
2013-02-12 0:02 ` Joe Perches
2013-02-12 0:00 ` [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Joe Perches
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2013-02-11 23:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Stephen Warren <swarren@nvidia.com>
The intent is to ensure that all Tegra-related patches are sent to the
linux-tegra@ mailing list, so people can keep up-to-date on all misc
driver changes.
Doing this with a keyword is far simpler and more compact than listing
all Tegra-related drivers, even if wildcards were used.
Words such as integrate or integrator are common. Ensure the character
right before "tegra" isn't a-z (case-insensitive), to make sure the
keyword doesn't match those.
The only files that the keyword doesn't match are the NVEC driver. Add
the linux-tegra mailing list to the NVEC entry to solve this.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
V2: Edit NVEC entry too.
MAINTAINERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b98c89b..0cfb670 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7531,6 +7531,7 @@ STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec)
M: Julian Andres Klode <jak@jak-linux.org>
M: Marc Dietrich <marvin24@gmx.de>
L: ac100 at lists.launchpad.net (moderated for non-subscribers)
+L: linux-tegra at vger.kernel.org
S: Maintained
F: drivers/staging/nvec/
@@ -7829,9 +7830,7 @@ L: linux-tegra at vger.kernel.org
Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
S: Supported
-F: arch/arm/mach-tegra
-F: arch/arm/boot/dts/tegra*
-F: arch/arm/configs/tegra_defconfig
+K: (?i)[^a-z]tegra
TEHUTI ETHERNET DRIVER
M: Andy Gospodarek <andy@greyhouse.net>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files
2013-02-11 23:40 ` [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
@ 2013-02-12 0:02 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2013-02-12 0:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The intent is to ensure that all Tegra-related patches are sent to the
> linux-tegra@ mailing list, so people can keep up-to-date on all misc
> driver changes.
>
> Doing this with a keyword is far simpler and more compact than listing
> all Tegra-related drivers, even if wildcards were used.
>
> Words such as integrate or integrator are common. Ensure the character
> right before "tegra" isn't a-z (case-insensitive), to make sure the
> keyword doesn't match those.
>
> The only files that the keyword doesn't match are the NVEC driver. Add
> the linux-tegra mailing list to the NVEC entry to solve this.
You should probably add some commentary/documentation
to the K: section description of MAINTAINERS in patch 1/2.
Something about K: patterns also matching filenames.
K: Keyword perl extended regex pattern to match content in a
patch or file. For instance:
K: of_get_profile
matches patches or files that contain "of_get_profile"
K: \b(printk|pr_(info|err))\b
matches patches or files that contain one or more of the words
printk, pr_info or pr_err
One regex pattern per line. Multiple K: lines acceptable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V3 1/2] get_maintainer: allow keywords to match filenames
2013-02-11 23:40 [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
2013-02-11 23:40 ` [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
@ 2013-02-12 0:00 ` Joe Perches
2013-02-12 0:08 ` Stephen Warren
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2013-02-12 0:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Allow K: entries in MAINTAINERS to match directly against filenames;
> either those extracted from patch +++ or --- lines, or those specified
> on the command-line using the -f option.
[]
> I don't think setting exact_pattern_match_hash would be appropriate here;
> at least for intended Tegra use case, this feature is to ensure that all
> Tegra-related driver changes get Cc'd to the Tegra mailing list. Setting
> exact_pattern_match_hash would prevent git history parsing for e.g. S-o-b
> tags, which still seems like it would be useful. Hence, this flag isn't
> set.
And I don't think that's necessary because for filenames,
you could add the appropriate control to the MAINTAINERS
"K: ^pattern$"
> The value in $hash{$tvi} doesn't seem relevant, so I just assign 0.
0 is good.
It would be relevant if --pattern-depth was set.
> Joe, I'm not sure if you care where this gets merged; could it go through
> arm-soc together with patch 2/2? A quick look at git history of the
> script in linux-next indicates there won't be conflicts doing that.
I don't care how it gets merged.
Andrew Morton typically picks these up but
if you want to get it merged separately,
I don't see a problem.
trivial comment below:
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -611,6 +611,10 @@ sub get_maintainers {
> $hash{$tvi} = $value_pd;
> }
> }
> + } elsif ($type eq "K") {
This should probably be 'K' to match the other
'F' use above it.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V3 1/2] get_maintainer: allow keywords to match filenames
2013-02-12 0:00 ` [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Joe Perches
@ 2013-02-12 0:08 ` Stephen Warren
2013-02-12 0:16 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2013-02-12 0:08 UTC (permalink / raw)
To: linux-arm-kernel
On 02/11/2013 05:00 PM, Joe Perches wrote:
> On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Allow K: entries in MAINTAINERS to match directly against filenames;
>> either those extracted from patch +++ or --- lines, or those specified
>> on the command-line using the -f option.
> []
>> I don't think setting exact_pattern_match_hash would be appropriate here;
>> at least for intended Tegra use case, this feature is to ensure that all
>> Tegra-related driver changes get Cc'd to the Tegra mailing list. Setting
>> exact_pattern_match_hash would prevent git history parsing for e.g. S-o-b
>> tags, which still seems like it would be useful. Hence, this flag isn't
>> set.
>
> And I don't think that's necessary because for filenames,
> you could add the appropriate control to the MAINTAINERS
>
> "K: ^pattern$"
Does "that" above mean "not setting exact_pattern_match_hash", or
"changing the patch so that it does set exact_pattern_match_hash". Sorry...
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-12 0:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-11 23:40 [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
2013-02-11 23:40 ` [PATCH V3 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
2013-02-12 0:02 ` Joe Perches
2013-02-12 0:00 ` [PATCH V3 1/2] get_maintainer: allow keywords to match filenames Joe Perches
2013-02-12 0:08 ` Stephen Warren
2013-02-12 0:16 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).