From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP3+: Fix kernel panic on boot
Date: Tue, 12 Feb 2013 10:15:56 -0600 [thread overview]
Message-ID: <511A6ABC.3080200@ti.com> (raw)
In-Reply-To: <20130212100747.GA20996@sortiz-mobl>
On 02/12/2013 04:07 AM, Samuel Ortiz wrote:
> Hi Jon,
>
> On Mon, Feb 11, 2013 at 02:26:19PM -0600, Jon Hunter wrote:
>> Commit 8a6aaa3 (mfd: twl-core: Collect global variables behind one
>> private structure (global)) removed the variable "inuse" that is used
>> to determine if the device has been initialised and now use the
>> twl_priv structure instead. This is causing the kernel to panic on
>> OMAP3+ devices using the twl driver, because we try to access the
>> twl_priv->ready member before checking if twl_priv is initialised. Fix
>> this and move this test to the beginning of the twl_i2c_read/write
>> function because twl_get_last_module() also uses the twl_priv structure.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> drivers/mfd/twl-core.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
> Patch applied, thanks.
> I fixed the subject as it's codewise not ARM or OMAP3 related, but rather mfd
> and twl-core.
Good point! Thanks Jon
prev parent reply other threads:[~2013-02-12 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 20:26 [PATCH] ARM: OMAP3+: Fix kernel panic on boot Jon Hunter
2013-02-12 10:07 ` Samuel Ortiz
2013-02-12 16:15 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A6ABC.3080200@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).