From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2 3/3] ARM: tegra: Unify Device tree board files
Date: Wed, 13 Feb 2013 09:50:25 -0700 [thread overview]
Message-ID: <511BC451.9050504@wwwdotorg.org> (raw)
In-Reply-To: <20130213.081240.1605796167151164030.hdoyu@nvidia.com>
On 02/12/2013 11:12 PM, Hiroshi Doyu wrote:
> Stephen Warren <swarren@wwwdotorg.org> wrote @ Tue, 12 Feb 2013 17:35:56 +0100:
>
>> However I'd like to avoid changing the body of those two functions at
>> all if possible, since I hope the PCIe driver rework will be merged in
>> 3.10, and that will allow the Harmony and TrimSlice init functions to be
>> removed entirely. I'd rather not have conflicts with the removal patch.
>>
>>> Since we are not going to add any other board specfic init functions, you
>>> can also unroll the loop and put everything into tegra_dt_init_late:
>>
>> That's not necessarily true. While we certainly don't plan to, I don't
>> think we can rule it out; after all, we don't have rfkill bindings and
>> yet other boards will need them.
>
> Considering the above points,
>
> - The Harmony and TrimSlice init functions will be removed entirely
> so soon that we want to avoid those merge conflicts as much as
> possible.
> - We may still need board specific init, especially for rfkill.
> - We want to build any combination of Tegra{20,30,114}, 2^3 - 1 == 7.
>
> The patch for "tegra.c" would be as below.
>
> Should I still keep the name, "tegra20_auxdata_lookup" to avoid
> any conflicts or "tegra_auxdata_lookup" would be ok for merge?
Yes, avoiding the rename of the auxdata table might be a good idea.
Aside from that, I think the patch you gave looks fine.
prev parent reply other threads:[~2013-02-13 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 6:05 [v2 1/3] ARM: tegra: Unify tegra{20,30,114}_init_early() Hiroshi Doyu
[not found] ` <1360562743-21689-3-git-send-email-hdoyu@nvidia.com>
2013-02-11 23:54 ` [v2 3/3] ARM: tegra: Unify Device tree board files Stephen Warren
2013-02-12 4:12 ` Hiroshi Doyu
2013-02-12 4:47 ` Stephen Warren
2013-02-12 5:04 ` Hiroshi Doyu
2013-02-12 13:50 ` Arnd Bergmann
2013-02-12 16:35 ` Stephen Warren
2013-02-12 17:32 ` Arnd Bergmann
2013-02-12 20:52 ` Stephen Warren
2013-02-12 22:25 ` Arnd Bergmann
2013-02-13 6:12 ` Hiroshi Doyu
2013-02-13 16:50 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511BC451.9050504@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).