[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Hiroshi Doyu]

Hi,

With new dtc+cpp feature, we could get rid of magic numbers in dts*
files. This patch replaces CLK IDs.

We also plan to share those DT header files with kernel source
later[1].

This series depends on:
  [PATCH 0/9] ARM: tegra: use new dtc+cpp feature
  http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149613.html

[5/6] and [6/6] depend on:
  [PATCH v6 00/10] Tegra114 clockframework
  http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148895.html

v2:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149816.html

v1:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149672.html

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html


Hiroshi Doyu (6):
  ARM: tegra20: create a DT header defining CLK IDs
  ARM: tegra20: convert device tree files to use CLK defines
  ARM: tegra30: create a DT header defining CLK IDs
  ARM: tegra30: convert device tree files to use CLK defines
  ARM: tegra114: create a DT header defining CLK IDs
  ARM: tegra114: convert device tree files to use CLK defines

 .../bindings/clock/nvidia,tegra114-car.txt         |  261 +------------------
 .../bindings/clock/nvidia,tegra20-car.txt          |  150 +----------
 .../bindings/clock/nvidia,tegra30-car.txt          |  207 +--------------
 arch/arm/boot/dts/tegra114-car.h                   |  272 ++++++++++++++++++++
 arch/arm/boot/dts/tegra114.dtsip                   |   13 +-
 arch/arm/boot/dts/tegra20-car.h                    |  158 ++++++++++++
 arch/arm/boot/dts/tegra20-paz00.dtsp               |    2 +-
 arch/arm/boot/dts/tegra20.dtsip                    |   85 +++---
 arch/arm/boot/dts/tegra30-car.h                    |  218 ++++++++++++++++
 arch/arm/boot/dts/tegra30.dtsip                    |   87 +++----
 10 files changed, 746 insertions(+), 707 deletions(-)
 create mode 100644 arch/arm/boot/dts/tegra114-car.h
 create mode 100644 arch/arm/boot/dts/tegra20-car.h
 create mode 100644 arch/arm/boot/dts/tegra30-car.h

-- 
1.7.9.5

[v3 2/6] ARM: tegra20: convert device tree files to use CLK defines

[Stephen Warren]

On 02/15/2013 01:43 AM, Hiroshi Doyu wrote:
> Replace magic number in tegra_car:
> 
> -               clocks = <&tegra_car 28>;
> +               clocks = <&tegra_car CLK_HOST1X>;
> 
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> ---
>  .../bindings/clock/nvidia,tegra20-car.txt          |  150 +-------------------

The edits to the binding are logically part of patch 1.

[v3 5/6] ARM: tegra114: create a DT header defining CLK IDs

[Stephen Warren]

On 02/15/2013 01:43 AM, Hiroshi Doyu wrote:
> To replace magic number in tegra_car:
> 
> -               clocks = <&tegra_car 28>;
> +               clocks = <&tegra_car CLK_HOST1X>;

Since the Tegra114-related files don't actually exist yet and hence
can't be applied, I think Peter should roll these patches into his
Tegra114 CCF series.

But perhaps hold off on that until Grant has a chance to ack/nak the
concept of doing this, and we've finalized on include path settings
etc., so there's no churn.

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Rob Landley]

On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
> Hi,
> 
> With new dtc+cpp feature, we could get rid of magic numbers in dts*
> files. This patch replaces CLK IDs.
> 
> We also plan to share those DT header files with kernel source
> later[1].
...
> [1]  
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html

This really smells like documentation should be updated, probably  
booting-without-of.txt or similar. Alas, I'm not capable of writing  
such an update...

Rob

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Stephen Warren]

On 02/17/2013 03:05 PM, Rob Landley wrote:
> On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
>> Hi,
>>
>> With new dtc+cpp feature, we could get rid of magic numbers in dts*
>> files. This patch replaces CLK IDs.
>>
>> We also plan to share those DT header files with kernel source
>> later[1].
> ...
>> [1]
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html
>>
> 
> This really smells like documentation should be updated, probably
> booting-without-of.txt or similar. Alas, I'm not capable of writing such
> an update...

I'm not sure what documentation would be updated nor why. Can you
describe that?

This patch is (or should be) editing the device tree binding
documentation to (include by) reference the header file that is being
added in this patch. I don't believe there's any more general
documentation that is affected by this series.

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Rob Landley]

On 02/19/2013 11:10:16 AM, Stephen Warren wrote:
> On 02/17/2013 03:05 PM, Rob Landley wrote:
> > On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
> >> Hi,
> >>
> >> With new dtc+cpp feature, we could get rid of magic numbers in dts*
> >> files. This patch replaces CLK IDs.
> >>
> >> We also plan to share those DT header files with kernel source
> >> later[1].
> > ...
> >> [1]
> >>  
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html
> >>
> >
> > This really smells like documentation should be updated, probably
> > booting-without-of.txt or similar. Alas, I'm not capable of writing  
> such
> > an update...
> 
> I'm not sure what documentation would be updated nor why. Can you
> describe that?

"When writing new device tree files, please do not include magic  
numbers. Here's how to avoid them."

Does something in Documentation already say this somewhere?

Rob

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Stephen Warren]

On 02/23/2013 12:51 PM, Rob Landley wrote:
> On 02/19/2013 11:10:16 AM, Stephen Warren wrote:
>> On 02/17/2013 03:05 PM, Rob Landley wrote:
>> > On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
>> >> Hi,
>> >>
>> >> With new dtc+cpp feature, we could get rid of magic numbers in dts*
>> >> files. This patch replaces CLK IDs.
>> >>
>> >> We also plan to share those DT header files with kernel source
>> >> later[1].
>> > ...
>> >> [1]
>> >>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html
>>
>> >>
>> >
>> > This really smells like documentation should be updated, probably
>> > booting-without-of.txt or similar. Alas, I'm not capable of writing
>> such
>> > an update...
>>
>> I'm not sure what documentation would be updated nor why. Can you
>> describe that?
> 
> "When writing new device tree files, please do not include magic
> numbers. Here's how to avoid them."
> 
> Does something in Documentation already say this somewhere?

This seems rather basic and not worth documenting. The technique is
identical to the use of header files in C/assembly/... code. I suppose
if we document that, then there would be an argument for documenting this.

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Simon Glass]

Hi Hiroshi,

On Fri, Feb 15, 2013 at 12:43 AM, Hiroshi Doyu <hdoyu@nvidia.com> wrote:
> Hi,
>
> With new dtc+cpp feature, we could get rid of magic numbers in dts*
> files. This patch replaces CLK IDs.
>
> We also plan to share those DT header files with kernel source
> later[1].
>
> This series depends on:
>   [PATCH 0/9] ARM: tegra: use new dtc+cpp feature
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149613.html
>
> [5/6] and [6/6] depend on:
>   [PATCH v6 00/10] Tegra114 clockframework
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148895.html
>
> v2:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149816.html
>
> v1:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149672.html
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html
>
>
> Hiroshi Doyu (6):
>   ARM: tegra20: create a DT header defining CLK IDs
>   ARM: tegra20: convert device tree files to use CLK defines
>   ARM: tegra30: create a DT header defining CLK IDs
>   ARM: tegra30: convert device tree files to use CLK defines
>   ARM: tegra114: create a DT header defining CLK IDs
>   ARM: tegra114: convert device tree files to use CLK defines

I wonder what sort of error message do you get when you make a mistake
in the .dts or one of the .dtsi includes? If cpp is handling the
including, does dtc just see a single file, in which case are the line
numbers printed with each error not much use? Or does dtc handle the
#line directives?

Just curious...

Regards,
Simon

>
>  .../bindings/clock/nvidia,tegra114-car.txt         |  261 +------------------
>  .../bindings/clock/nvidia,tegra20-car.txt          |  150 +----------
>  .../bindings/clock/nvidia,tegra30-car.txt          |  207 +--------------
>  arch/arm/boot/dts/tegra114-car.h                   |  272 ++++++++++++++++++++
>  arch/arm/boot/dts/tegra114.dtsip                   |   13 +-
>  arch/arm/boot/dts/tegra20-car.h                    |  158 ++++++++++++
>  arch/arm/boot/dts/tegra20-paz00.dtsp               |    2 +-
>  arch/arm/boot/dts/tegra20.dtsip                    |   85 +++---
>  arch/arm/boot/dts/tegra30-car.h                    |  218 ++++++++++++++++
>  arch/arm/boot/dts/tegra30.dtsip                    |   87 +++----
>  10 files changed, 746 insertions(+), 707 deletions(-)
>  create mode 100644 arch/arm/boot/dts/tegra114-car.h
>  create mode 100644 arch/arm/boot/dts/tegra20-car.h
>  create mode 100644 arch/arm/boot/dts/tegra30-car.h
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v3 0/6] ARM: tegra: convert device tree files to use CLK defines

[Stephen Warren]

On 02/17/2013 03:20 PM, Simon Glass wrote:
> Hi Hiroshi,
> 
> On Fri, Feb 15, 2013 at 12:43 AM, Hiroshi Doyu <hdoyu@nvidia.com> wrote:
>> Hi,
>>
>> With new dtc+cpp feature, we could get rid of magic numbers in dts*
>> files. This patch replaces CLK IDs.
...
> I wonder what sort of error message do you get when you make a mistake
> in the .dts or one of the .dtsi includes? If cpp is handling the
> including, does dtc just see a single file,

It is.

> in which case are the line
> numbers printed with each error not much use? Or does dtc handle the
> #line directives?

cpp does generate #line directives, which dtc does know how to
interpret, so this should all work just fine. IIRC, I did test out this
aspect when adding #line support to dtc.