From: dirk.behme@gmail.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:kernel: a bug by a redundancy charactor ';'
Date: Sat, 16 Feb 2013 09:04:28 +0100 [thread overview]
Message-ID: <511F3D8C.6090603@gmail.com> (raw)
In-Reply-To: <511F2C0D.4030206@asianux.com>
Am 16.02.2013 07:49, schrieb Chen Gang:
>
> delete the redundancy charactor ';', which will cause issue.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/kernel/perf_event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 31e0eb3..a892067 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
> }
>
> if (event->group_leader != event) {
> - if (validate_group(event) != 0);
> + if (validate_group(event) != 0)
> return -EINVAL;
> }
Wondering against which branch this patch is, I found that this issue
isn't in recent mainline from today, but in -next. Introduced by the patch
ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a
While the subject/commit message could be improved (at least
mentioning 'perf' somehow and charactor -> character), the change
itself looks good.
Best regards
Dirk
next prev parent reply other threads:[~2013-02-16 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 6:49 [PATCH] ARM:kernel: a bug by a redundancy charactor ';' Chen Gang
2013-02-16 8:04 ` Dirk Behme [this message]
2013-02-16 8:38 ` Chen Gang
2013-02-16 12:26 ` Will Deacon
2013-02-16 13:44 ` Dirk Behme
2013-02-17 2:07 ` Chen Gang
2013-02-17 2:09 ` [PATCH] ARM:kernel: a bug for perf by a redundancy character ';' Chen Gang
2013-02-17 4:22 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F3D8C.6090603@gmail.com \
--to=dirk.behme@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).