public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM:kernel: a bug for perf by a redundancy character ';'
@ 2013-02-17  4:27 Chen Gang
  2013-02-17  6:31 ` Dirk Behme
  0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-02-17  4:27 UTC (permalink / raw)
  To: linux-arm-kernel


  delete the redundancy character ';', which will cause issue.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Dirk Behme <dirk.behme@gmail.com>
---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 31e0eb3..a892067 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}
 
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2] ARM:kernel: a bug for perf by a redundancy character ';'
  2013-02-17  4:27 [PATCH v2] ARM:kernel: a bug for perf by a redundancy character ';' Chen Gang
@ 2013-02-17  6:31 ` Dirk Behme
  2013-02-17  6:57   ` Chen Gang
  0 siblings, 1 reply; 3+ messages in thread
From: Dirk Behme @ 2013-02-17  6:31 UTC (permalink / raw)
  To: linux-arm-kernel

Am 17.02.2013 05:27, schrieb Chen Gang:
> 
>    delete the redundancy character ';', which will cause issue.
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Acked-by: Dirk Behme <dirk.behme@gmail.com>

I would prefer Will's version of the subject and commit message

http://git.kernel.org/?p=linux/kernel/git/will/linux.git;a=commitdiff;h=21fa771c94c4359807bb92dc8532b25c323ac543

And, btw, the Ack was for Will's version ;)

Dirk

> ---
>   arch/arm/kernel/perf_event.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 31e0eb3..a892067 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
>   	}
>   
>   	if (event->group_leader != event) {
> -		if (validate_group(event) != 0);
> +		if (validate_group(event) != 0)
>   			return -EINVAL;
>   	}
>   
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] ARM:kernel: a bug for perf by a redundancy character ';'
  2013-02-17  6:31 ` Dirk Behme
@ 2013-02-17  6:57   ` Chen Gang
  0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-02-17  6:57 UTC (permalink / raw)
  To: linux-arm-kernel

? 2013?02?17? 14:31, Dirk Behme ??:
> I would prefer Will's version of the subject and commit message
> 
> http://git.kernel.org/?p=linux/kernel/git/will/linux.git;a=commitdiff;h=21fa771c94c4359807bb92dc8532b25c323ac543
> 
> And, btw, the Ack was for Will's version ;)


  oh, thank you. I did not see carefully.

  :-)

-- 
Chen Gang

Asianux Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-02-17  6:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-17  4:27 [PATCH v2] ARM:kernel: a bug for perf by a redundancy character ';' Chen Gang
2013-02-17  6:31 ` Dirk Behme
2013-02-17  6:57   ` Chen Gang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox