From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/acpi: Add fixup for HPE m400 quirks
Date: Fri, 15 Jun 2018 13:33:15 -0400 [thread overview]
Message-ID: <5120aa9f167c19712c01dc812f689eaef23bf0c5.camel@redhat.com> (raw)
In-Reply-To: <8a3034b9-6cf3-5182-717f-dd1dc8a087aa@infradead.org>
On Fri, 2018-06-15 at 10:17 -0700, Geoff Levand wrote:
> > > + if (ACPI_SUCCESS(status) && !strncmp(header->oem_id, "HPE ", 6) &&
> > > + !strncmp(header->oem_table_id, "ProLiant", 8) &&
> >
> > You should match the affected range of OEM table revisions too, that way a
> > firmware upgrade should start working, instead of being permanently disabled
> > because we think its unlikely.
>
> The m400 has reached end of life. No one really expects to see any firmware
> update. I don't know what the effected OEM table revisions are, and I don't
> think there is an active platform maintainer who could give that info either.
>
> If someone can provide the info. I'll update the fix.
>
> > > + MIDR_IMPLEMENTOR(read_cpuid_id()) == ARM_CPU_IMP_APM) {
> >
> > How is the CPU implementer relevant?
>
> That was just a copy of what other fixes had. Should I remove it?
It was there because HPE ProLiant strings are generic and you may end up
disabling platforms which would otherwise work. It is the ProLiant system
based on the APM chipset which is the problem. Thus the check for cpu
implementor.
next prev parent reply other threads:[~2018-06-15 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 18:22 [PATCH] arm64/acpi: Add fixup for HPE m400 quirks Geoff Levand
2018-06-15 8:47 ` Riku Voipio
2018-06-15 9:51 ` Graeme Gregory
2018-06-15 11:14 ` James Morse
2018-06-15 17:17 ` Geoff Levand
2018-06-15 17:33 ` Mark Salter [this message]
2018-06-15 18:15 ` Geoff Levand
2018-06-15 19:14 ` Mark Salter
2018-06-18 16:18 ` James Morse
2018-06-18 18:04 ` Geoff Levand
2018-06-18 22:18 ` Mark Salter
2018-06-19 10:21 ` James Morse
2018-06-22 15:19 ` Mark Salter
2018-06-25 15:34 ` Mark Salter
2018-06-26 14:51 ` James Morse
2018-06-26 20:20 ` Mark Salter
2018-06-27 8:48 ` Ard Biesheuvel
2018-06-27 12:25 ` Mark Salter
2018-07-03 9:30 ` Ian Campbell
2018-07-03 15:20 ` Mark Salter
2018-06-28 10:06 ` James Morse
2018-06-29 13:05 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5120aa9f167c19712c01dc812f689eaef23bf0c5.camel@redhat.com \
--to=msalter@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).