From: masami.hiramatsu.pt@hitachi.com (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG arm-soc] mvneta: tx queue done sometimes causes kernel panic
Date: Mon, 18 Feb 2013 23:34:36 +0900 [thread overview]
Message-ID: <51223BFC.3000408@hitachi.com> (raw)
In-Reply-To: <20130216022043.65d5c940@skate>
(2013/02/16 10:20), Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 15 Feb 2013 08:52:12 -0800, Eric Dumazet wrote:
>
>> Driver is buggy, as TX completion can happen both from ndo_start_xmit()
>> and a timer, and there is no spinlock or appropriate synchro.
>
> Yes, it is a known issue. I did post a patch fixing the problem on
> netdev@ a while ago [1], but while it was fixing the problem, it wasn't
> considered the right approach. Being busy with other Marvell Armada
> 370/XP developments, I haven't yet had the time to investigate the
> issue again.
>
> [1] https://patchwork.kernel.org/patch/1941601/
Thank you for pointing that.
I've tried the above patch and found at least this panic
disappeared (even if it was not the right approach).
Thanks again!
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt at hitachi.com
prev parent reply other threads:[~2013-02-18 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <511DE679.5080801@hitachi.com>
2013-02-15 16:52 ` [BUG arm-soc] mvneta: tx queue done sometimes causes kernel panic Eric Dumazet
2013-02-16 1:20 ` Thomas Petazzoni
2013-02-18 14:34 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51223BFC.3000408@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).