* [PATCH] irqchip: fix typo when moving gic_raise_softirq()
@ 2013-02-19 13:52 Javi Merino
2013-02-19 13:57 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Javi Merino @ 2013-02-19 13:52 UTC (permalink / raw)
To: linux-arm-kernel
In b1cffebf (ARM: GIC: remove direct use of gic_raise_softirq)
gic_raise_softirq() was moved inside arch/arm/common/gic.c but in the
process it reverted by mistake a change to that function made by
384a290 (ARM: gic: use a private mapping for CPU target interfaces).
This breaks multicluster systems on ARM.
This patch fixes the typo.
Cc: Olof Johansson <olof@lixom.net>
Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Javi Merino <javi.merino@arm.com>
---
drivers/irqchip/irq-gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 644d724..a32e0d5 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -648,7 +648,7 @@ void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
/* Convert our logical CPU mask into a physical one. */
for_each_cpu(cpu, mask)
- map |= 1 << cpu_logical_map(cpu);
+ map |= gic_cpu_map[cpu];
/*
* Ensure that stores to Normal memory are visible to the
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] irqchip: fix typo when moving gic_raise_softirq()
2013-02-19 13:52 [PATCH] irqchip: fix typo when moving gic_raise_softirq() Javi Merino
@ 2013-02-19 13:57 ` Rob Herring
2013-02-26 7:05 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2013-02-19 13:57 UTC (permalink / raw)
To: linux-arm-kernel
On 02/19/2013 07:52 AM, Javi Merino wrote:
> In b1cffebf (ARM: GIC: remove direct use of gic_raise_softirq)
> gic_raise_softirq() was moved inside arch/arm/common/gic.c but in the
> process it reverted by mistake a change to that function made by
> 384a290 (ARM: gic: use a private mapping for CPU target interfaces).
> This breaks multicluster systems on ARM.
>
> This patch fixes the typo.
>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>
I wouldn't really call this a typo, but a rebasing error. Not really
important though, so:
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/irqchip/irq-gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 644d724..a32e0d5 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -648,7 +648,7 @@ void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
>
> /* Convert our logical CPU mask into a physical one. */
> for_each_cpu(cpu, mask)
> - map |= 1 << cpu_logical_map(cpu);
> + map |= gic_cpu_map[cpu];
>
> /*
> * Ensure that stores to Normal memory are visible to the
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] irqchip: fix typo when moving gic_raise_softirq()
2013-02-19 13:57 ` Rob Herring
@ 2013-02-26 7:05 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2013-02-26 7:05 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 19, 2013 at 07:57:36AM -0600, Rob Herring wrote:
> On 02/19/2013 07:52 AM, Javi Merino wrote:
> > In b1cffebf (ARM: GIC: remove direct use of gic_raise_softirq)
> > gic_raise_softirq() was moved inside arch/arm/common/gic.c but in the
> > process it reverted by mistake a change to that function made by
> > 384a290 (ARM: gic: use a private mapping for CPU target interfaces).
> > This breaks multicluster systems on ARM.
> >
> > This patch fixes the typo.
> >
> > Cc: Olof Johansson <olof@lixom.net>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Javi Merino <javi.merino@arm.com>
>
> I wouldn't really call this a typo, but a rebasing error. Not really
> important though, so:
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
Applied.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-26 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 13:52 [PATCH] irqchip: fix typo when moving gic_raise_softirq() Javi Merino
2013-02-19 13:57 ` Rob Herring
2013-02-26 7:05 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).