* [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
@ 2013-03-05 11:09 Aaro Koskinen
2013-03-05 11:36 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Aaro Koskinen @ 2013-03-05 11:09 UTC (permalink / raw)
To: linux-arm-kernel
Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
add phy binding for RX-51, and as a result USB does not work anymore on
3.9-rc1. Add the missing binding.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
arch/arm/mach-omap2/board-rx51.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
index f7c4616..d2ea68e 100644
--- a/arch/arm/mach-omap2/board-rx51.c
+++ b/arch/arm/mach-omap2/board-rx51.c
@@ -17,6 +17,7 @@
#include <linux/io.h>
#include <linux/gpio.h>
#include <linux/leds.h>
+#include <linux/usb/phy.h>
#include <linux/usb/musb.h>
#include <linux/platform_data/spi-omap2-mcspi.h>
@@ -98,6 +99,7 @@ static void __init rx51_init(void)
sdrc_params = nokia_get_sdram_timings();
omap_sdrc_init(sdrc_params, sdrc_params);
+ usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
usb_musb_init(&musb_board_data);
rx51_peripherals_init();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
2013-03-05 11:09 [PATCH] ARM: OMAP: RX-51: add missing USB phy binding Aaro Koskinen
@ 2013-03-05 11:36 ` Felipe Balbi
2013-03-05 11:41 ` kishon
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2013-03-05 11:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
> add phy binding for RX-51, and as a result USB does not work anymore on
> 3.9-rc1. Add the missing binding.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/board-rx51.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
> index f7c4616..d2ea68e 100644
> --- a/arch/arm/mach-omap2/board-rx51.c
> +++ b/arch/arm/mach-omap2/board-rx51.c
> @@ -17,6 +17,7 @@
> #include <linux/io.h>
> #include <linux/gpio.h>
> #include <linux/leds.h>
> +#include <linux/usb/phy.h>
> #include <linux/usb/musb.h>
> #include <linux/platform_data/spi-omap2-mcspi.h>
>
> @@ -98,6 +99,7 @@ static void __init rx51_init(void)
> sdrc_params = nokia_get_sdram_timings();
> omap_sdrc_init(sdrc_params, sdrc_params);
>
> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
> usb_musb_init(&musb_board_data);
> rx51_peripherals_init();
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130305/e19e9ba6/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
2013-03-05 11:36 ` Felipe Balbi
@ 2013-03-05 11:41 ` kishon
2013-03-05 16:26 ` Tony Lindgren
2013-03-06 9:10 ` kishon
0 siblings, 2 replies; 5+ messages in thread
From: kishon @ 2013-03-05 11:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote:
> On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
>> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
>> add phy binding for RX-51, and as a result USB does not work anymore on
>> 3.9-rc1. Add the missing binding.
>>
>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>> ---
>> arch/arm/mach-omap2/board-rx51.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
>> index f7c4616..d2ea68e 100644
>> --- a/arch/arm/mach-omap2/board-rx51.c
>> +++ b/arch/arm/mach-omap2/board-rx51.c
>> @@ -17,6 +17,7 @@
>> #include <linux/io.h>
>> #include <linux/gpio.h>
>> #include <linux/leds.h>
>> +#include <linux/usb/phy.h>
>> #include <linux/usb/musb.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>>
>> @@ -98,6 +99,7 @@ static void __init rx51_init(void)
>> sdrc_params = nokia_get_sdram_timings();
>> omap_sdrc_init(sdrc_params, sdrc_params);
>>
>> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> usb_musb_init(&musb_board_data);
>> rx51_peripherals_init();
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
2013-03-05 11:41 ` kishon
@ 2013-03-05 16:26 ` Tony Lindgren
2013-03-06 9:10 ` kishon
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2013-03-05 16:26 UTC (permalink / raw)
To: linux-arm-kernel
* kishon <kishon@ti.com> [130305 03:46]:
> On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote:
> >On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
> >>Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
> >>add phy binding for RX-51, and as a result USB does not work anymore on
> >>3.9-rc1. Add the missing binding.
> >>
> >>Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> >
> >Acked-by: Felipe Balbi <balbi@ti.com>
> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
Thanks, applying into omap-for-v3.9-rc1/fixes.
Regards,
Tony
> >>---
> >> arch/arm/mach-omap2/board-rx51.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >>diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
> >>index f7c4616..d2ea68e 100644
> >>--- a/arch/arm/mach-omap2/board-rx51.c
> >>+++ b/arch/arm/mach-omap2/board-rx51.c
> >>@@ -17,6 +17,7 @@
> >> #include <linux/io.h>
> >> #include <linux/gpio.h>
> >> #include <linux/leds.h>
> >>+#include <linux/usb/phy.h>
> >> #include <linux/usb/musb.h>
> >> #include <linux/platform_data/spi-omap2-mcspi.h>
> >>
> >>@@ -98,6 +99,7 @@ static void __init rx51_init(void)
> >> sdrc_params = nokia_get_sdram_timings();
> >> omap_sdrc_init(sdrc_params, sdrc_params);
> >>
> >>+ usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
> >> usb_musb_init(&musb_board_data);
> >> rx51_peripherals_init();
> >>
> >>--
> >>1.7.10.4
> >>
> >>--
> >>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> >>the body of a message to majordomo at vger.kernel.org
> >>More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
2013-03-05 11:41 ` kishon
2013-03-05 16:26 ` Tony Lindgren
@ 2013-03-06 9:10 ` kishon
1 sibling, 0 replies; 5+ messages in thread
From: kishon @ 2013-03-06 9:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tuesday 05 March 2013 05:11 PM, kishon wrote:
> On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote:
>> On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
>>> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
>>> add phy binding for RX-51, and as a result USB does not work anymore on
>>> 3.9-rc1. Add the missing binding.
>>>
>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>
>> Acked-by: Felipe Balbi <balbi@ti.com>
> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
Btw I dint add usb_bind_phy for board-am3517evm.c, board-ti8168evm.c too
since those board files also dint have any reference to twl4030/twl6030.
Can someone let me know what phy these platforms use or provide a patch
for the same?
Thanks
Kishon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-06 9:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 11:09 [PATCH] ARM: OMAP: RX-51: add missing USB phy binding Aaro Koskinen
2013-03-05 11:36 ` Felipe Balbi
2013-03-05 11:41 ` kishon
2013-03-05 16:26 ` Tony Lindgren
2013-03-06 9:10 ` kishon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).