From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B182C43381 for ; Tue, 26 Mar 2019 11:59:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D87D02075C for ; Tue, 26 Mar 2019 11:59:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j1AlGWeQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D87D02075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rqZLu1S+oUJ9cTD2CFbP+63DOEQU1gMvTybLu7k4rzU=; b=j1AlGWeQSWcM/I TK1Hwx5fw+5k8p8SHwVOiFvBw+tTZovIEeJuCAF9//oSHLiu6HM0BqClDd4tRa0LJVliAgOVbOd6/ LdzknyCN+fymZ0kovW7+6RxGjbfyLawhqePIyOTY4N3DawBXY70MuUjzfnICdHJaKubeDSkq2FyQY Pf8LjPBMDh+fxydSZ50VMw0jiNd6FDflNzBR3/Y+i+WU1eQoWO2UuVP/OsnVHrGRIKnptbkgI7qYC Ug3onPjtqpW+Yquh6SjrPL9difRBIrafdnCe5TpyDREl9MOstb7NYY12MYFjEWwL/HzSQqbx6f+jH SpGWWZS3WTBWHiIgqP/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8kjm-0004xq-KB; Tue, 26 Mar 2019 11:59:26 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8kjh-0004x2-Mc for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 11:59:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E70691596; Tue, 26 Mar 2019 04:59:18 -0700 (PDT) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 025B73F59C; Tue, 26 Mar 2019 04:59:17 -0700 (PDT) Subject: Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check To: Mukesh Ojha , Sudeep Holla , linux-arm-kernel@lists.infradead.org References: <20190325173722.49414-1-steven.price@arm.com> From: Steven Price Message-ID: <5135e6df-4977-bd97-95d9-300c12c9e073@arm.com> Date: Tue, 26 Mar 2019 11:59:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_045921_742328_B976828D X-CRM114-Status: GOOD ( 23.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjYvMDMvMjAxOSAwNzoyMywgTXVrZXNoIE9qaGEgd3JvdGU6Cj4gCj4gT24gMy8yNS8yMDE5 IDExOjA3IFBNLCBTdGV2ZW4gUHJpY2Ugd3JvdGU6Cj4+IG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9h cmdzKCkgcmVxdWlyZXMgdGhlIGNhbGxlciB0byBjYWxsIG9mX25vZGVfcHV0KCkgb24KPj4gdGhl IHJldHVybmVkIGFyZ3MtPm5wIHBvaW50ZXIuIE90aGVyd2lzZSB0aGUgcmVmZXJlbmNlIGNvdW50 IHdpbGwgcmVtYWluCj4+IGluY3JlbWVudGVkLgo+Pgo+PiBIb3dldmVyLCBpbiB0aGlzIGNhc2Us IHNpbmNlIHdlIGRvbid0IGFjdHVhbGx5IHVzZSB0aGUgcmV0dXJuZWQgcG9pbnRlciwKPj4gd2Ug Y2FuIHNpbXBseSBwYXNzIGluIE5VTEwuCj4+Cj4+IEZpeGVzOiBhYTRmODg2ZjM4OTNmICgiZmly bXdhcmU6IGFybV9zY21pOiBhZGQgYmFzaWMgZHJpdmVyCj4+IGluZnJhc3RydWN0dXJlIGZvciBT Q01JIikKPj4gU2lnbmVkLW9mZi1ieTogU3RldmVuIFByaWNlIDxzdGV2ZW4ucHJpY2VAYXJtLmNv bT4KPj4gLS0tCj4+IMKgIGRyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkvZHJpdmVyLmMgfCA0ICst LS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9ucygtKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9kcml2ZXIuYwo+PiBi L2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkvZHJpdmVyLmMKPj4gaW5kZXggOGY5NTJmMmYxYTI5 Li5kZDk2N2Q2NzVjMDggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkv ZHJpdmVyLmMKPj4gKysrIGIvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9kcml2ZXIuYwo+PiBA QCAtNjU0LDkgKzY1NCw3IEBAIHN0YXRpYyBpbnQgc2NtaV94ZmVyX2luZm9faW5pdChzdHJ1Y3Qg c2NtaV9pbmZvCj4+ICpzaW5mbykKPj4gwqAgwqAgc3RhdGljIGludCBzY21pX21haWxib3hfY2hl Y2soc3RydWN0IGRldmljZV9ub2RlICpucCkKPj4gwqAgewo+PiAtwqDCoMKgIHN0cnVjdCBvZl9w aGFuZGxlX2FyZ3MgYXJnOwo+PiAtCj4+IC3CoMKgwqAgcmV0dXJuIG9mX3BhcnNlX3BoYW5kbGVf d2l0aF9hcmdzKG5wLCAibWJveGVzIiwgIiNtYm94LWNlbGxzIiwgMCwKPj4gJmFyZyk7Cj4+ICvC oMKgwqAgcmV0dXJuIG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKG5wLCAibWJveGVzIiwgIiNt Ym94LWNlbGxzIiwgMCwKPj4gTlVMTCk7Cj4gCj4gQWx0aG91Z2gsIGl0IGlzIG5vdCB1c2VkIGJ1 dCBpdCBpcyBiZXR0ZXIgdG8gcHV0IGFyZy0+bnAgaW5zdGVhZCBvZgo+IHBhc3NpbmcgTlVMTC4K PiBIZXJlLCB5b3UgYXJlIG1ha2luZyB0aGUgZHJpdmVyIG5vdCB0byBmaWxsIGFyZ3VlbWVudCB3 aGljaCBpcwo+IGN1c3RvbWlzZWQgc29sdXRpb24sIHRoYXQgbWF5IGNoYW5nZSBpbiBmdXR1cmUu CgpUaGUgZnVuY3Rpb24gb2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3MoKSBpcyBkb2N1bWVudGVk IHRodXM6Cgo+ICAqIG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKCkgLSBGaW5kIGEgbm9kZSBw b2ludGVkIGJ5IHBoYW5kbGUgaW4gYSBsaXN0Cj4gICogQG5wOgkJcG9pbnRlciB0byBhIGRldmlj ZSB0cmVlIG5vZGUgY29udGFpbmluZyBhIGxpc3QKPiAgKiBAbGlzdF9uYW1lOglwcm9wZXJ0eSBu YW1lIHRoYXQgY29udGFpbnMgYSBsaXN0Cj4gICogQGNlbGxzX25hbWU6CXByb3BlcnR5IG5hbWUg dGhhdCBzcGVjaWZpZXMgcGhhbmRsZXMnIGFyZ3VtZW50cyBjb3VudAo+ICAqIEBpbmRleDoJaW5k ZXggb2YgYSBwaGFuZGxlIHRvIHBhcnNlIG91dAo+ICAqIEBvdXRfYXJnczoJb3B0aW9uYWwgcG9p bnRlciB0byBvdXRwdXQgYXJndW1lbnRzIHN0cnVjdHVyZSAod2lsbCBiZSBmaWxsZWQpCgpTbyBJ J20gZ29pbmcgYnkgdGhlIGRvY3VtZW50YXRpb24gKGFuZCBpbXBsZW1lbnRhdGlvbikgd2hpY2gg Ym90aApjb25zaWRlciBvdXRfYXJncyB0byBiZSBvcHRpb25hbC4gVGhlIGFsdGVybmF0aXZlIGlz IG9mIGNvdXJzZToKCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkvZHJp dmVyLmMgYi9kcml2ZXJzL2Zpcm13YXJlL2FybV9zY21pL2RyaXZlci5jCj4gaW5kZXggOGY5NTJm MmYxYTI5Li5hYTZjMDcyOGU2NzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9maXJtd2FyZS9hcm1f c2NtaS9kcml2ZXIuYwo+ICsrKyBiL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkvZHJpdmVyLmMK PiBAQCAtNjU1LDggKzY1NSwxMSBAQCBzdGF0aWMgaW50IHNjbWlfeGZlcl9pbmZvX2luaXQoc3Ry dWN0IHNjbWlfaW5mbyAqc2luZm8pCj4gIHN0YXRpYyBpbnQgc2NtaV9tYWlsYm94X2NoZWNrKHN0 cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gIHsKPiAgCXN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgYXJn Owo+ICsJaW50IHJldDsKPiAgCj4gLQlyZXR1cm4gb2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3Mo bnAsICJtYm94ZXMiLCAiI21ib3gtY2VsbHMiLCAwLCAmYXJnKTsKPiArCXJldCA9IG9mX3BhcnNl X3BoYW5kbGVfd2l0aF9hcmdzKG5wLCAibWJveGVzIiwgIiNtYm94LWNlbGxzIiwgMCwgJmFyZyk7 Cj4gKwlvZl9ub2RlX3B1dChhcmctPm5wKTsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0 YXRpYyBpbnQgc2NtaV9tYm94X2ZyZWVfY2hhbm5lbChpbnQgaWQsIHZvaWQgKnAsIHZvaWQgKmRh dGEpCgpCdXQgcGVyc29uYWxseSB0aGF0IGRvZXNuJ3Qgc2VlbSBhcyBnb29kLiBJcyB0aGVyZSBh bnkgcmVhc29uIHRvIHRoaW5rCnRoZSBpbnRlcmZhY2Ugb2Ygb2ZfcGFyc2VfcGhhbmRsZV93aXRo X2FyZ3MoKSB3aWxsIGNoYW5nZT8KClN0ZXZlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==