From: Josua Mayer <josua@solid-run.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Marek Vasut <marex@denx.de>, Fabio Estevam <festevam@denx.de>,
Stefan Wahren <stefan.wahren@chargebyte.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
Date: Fri, 16 Jun 2023 16:32:01 +0300 [thread overview]
Message-ID: <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> (raw)
In-Reply-To: <a9098664-ac16-eddb-3e2d-78eb08ac973f@linaro.org>
HI Krzysztof,
Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:
> On 16/06/2023 13:06, Josua Mayer wrote:
>> Add DT compatible for SolidRun LX2162A SoM and Clearfog board.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 15d411084065..438a4ece8157 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1373,9 +1373,11 @@ properties:
>> - description: SolidRun LX2160A based Boards
>> items:
>> - enum:
>> + - solidrun,clearfog
>> - solidrun,clearfog-cx
>> - solidrun,honeycomb
>> - const: solidrun,lx2160a-cex7
>> + - const: solidrun,lx2162a-som
>> - const: fsl,lx2160a
> You change existing entries, breaking boards and changing the meaning,
> without any explanation in commit msg. That's not how it is done. Please
> provide rationale in commit msg.
I'm sorry. Given your comment I think I did not understand how these
entries are supposed to work.
So perhaps you can provide some guidance based on my explanation?:
- NXP LX2162 is a smaller physical package of the same LX2160 SoC, with
reduced IOs and some silicon blocks disabled.
- SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX
- SolidRun LX2162 Clearfog is the reference platform for the SoM.
Despite it's naming similarity to clearfog-cx, it has a different
feature set more similar to SolidRun Armada 388 Clearfog Pro
So I believed I could just add to the existing entry "SolidRun LX2160A
based Boards" also the new LX2162 Board & SoM.
I see now that adding a fourth const messes upthe existing 3-part
compatible for those already existing boards.
Please can you confirm if it would have been more correct to replace
"const: solidrun,lx2160a-cex7" with an enum?:
enum:
- solidrun,lx2160a-cex7
- solidrun,lx2162a-som
Finally, is it okay to add a "solidrun,clearfog" given my explanation
above, or should it be more specific "solidrun,lx2162a-clearfog"?
> Best regards,
> Krzysztof
Sincerely
Josua Mayer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-16 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 11:06 [PATCH 0/3] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board Josua Mayer
2023-06-16 11:06 ` [PATCH 1/3] arm64: dts: lx2160a: describe the SerDes block #2 Josua Mayer
2023-06-16 11:06 ` [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board Josua Mayer
2023-06-16 11:36 ` Krzysztof Kozlowski
2023-06-16 13:32 ` Josua Mayer [this message]
2023-06-16 16:57 ` Andreas Kemnade
2023-06-17 13:34 ` Josua Mayer
2023-06-16 16:59 ` Krzysztof Kozlowski
2023-06-17 14:09 ` Josua Mayer
2023-06-16 11:06 ` [PATCH 3/3] arm64: dts: freescale: Add support for LX2162 " Josua Mayer
2023-06-16 11:39 ` Krzysztof Kozlowski
2023-06-16 12:57 ` Josua Mayer
2023-06-16 16:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com \
--to=josua@solid-run.com \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).