From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy
Date: Fri, 08 Mar 2013 17:39:53 +0100 [thread overview]
Message-ID: <513A1459.6010000@pengutronix.de> (raw)
In-Reply-To: <20130308163339.GG32368@arwen.pp.htv.fi>
On 03/08/2013 05:33 PM, Felipe Balbi wrote:
> On Thu, Feb 28, 2013 at 11:57:04AM +0100, Marc Kleine-Budde wrote:
>> @@ -147,19 +146,20 @@ static int ci13xxx_imx_probe(struct platform_device *pdev)
>> return ret;
>> }
>>
>> - phy_np = of_parse_phandle(pdev->dev.of_node, "fsl,usbphy", 0);
>> - if (phy_np) {
>> - data->phy_np = phy_np;
>> - phy_pdev = of_find_device_by_node(phy_np);
>> - if (phy_pdev) {
>> - struct usb_phy *phy;
>> - phy = pdev_to_phy(phy_pdev);
>> - if (phy &&
>> - try_module_get(phy_pdev->dev.driver->owner)) {
>> - usb_phy_init(phy);
>> - data->phy = phy;
>> - }
>> + phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy", 0);
>
> very nice, but should be done at chipidea core.
Any suggestions for the phandle name? "chipidea,usbphy"?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130308/e9867bb3/attachment.sig>
next prev parent reply other threads:[~2013-03-08 16:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 10:56 [PATCH 0/5] chipidea-for-v3.10-v2: USB chipidea: make use of DT helpers in chipidea driver improve driver Marc Kleine-Budde
2013-02-28 10:57 ` [PATCH 1/5] USB chipidea: ci13xxx-imx: create dynamic platformdata Marc Kleine-Budde
2013-03-08 16:30 ` Felipe Balbi
2013-02-28 10:57 ` [PATCH 2/5] USB chipidea: add PTW and PTS handling Marc Kleine-Budde
2013-03-28 11:20 ` Alexander Shishkin
2013-02-28 10:57 ` [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags Marc Kleine-Budde
2013-03-08 16:33 ` Felipe Balbi
2013-03-08 16:46 ` Alexander Shishkin
2013-03-08 16:52 ` Marc Kleine-Budde
2013-03-08 20:55 ` Alexander Shishkin
2013-03-10 14:38 ` Felipe Balbi
2013-03-28 11:13 ` Alexander Shishkin
2013-03-28 11:44 ` Felipe Balbi
2013-03-28 13:18 ` Alexander Shishkin
2013-04-02 8:02 ` Felipe Balbi
2013-02-28 10:57 ` [PATCH 4/5] USB chipidea i.MX: introduce dr_mode property Marc Kleine-Budde
2013-02-28 10:57 ` [PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Marc Kleine-Budde
2013-03-08 16:33 ` Felipe Balbi
2013-03-08 16:39 ` Marc Kleine-Budde [this message]
2013-03-10 14:39 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2013-02-27 14:20 [PATCH 0/5] chipidea-for-v3.10-v1: USB chipidea: make use of DT helpers in chipidea driver improve driver Marc Kleine-Budde
2013-02-27 14:20 ` [PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A1459.6010000@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).