From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: DT: tegra114: add APB DMA controller DT entry
Date: Sat, 9 Mar 2013 00:16:24 +0530 [thread overview]
Message-ID: <513A3200.8070905@nvidia.com> (raw)
In-Reply-To: <513A30D3.4020700@wwwdotorg.org>
On Saturday 09 March 2013 12:11 AM, Stephen Warren wrote:
> On 03/08/2013 11:06 AM, Laxman Dewangan wrote:
>> On Friday 08 March 2013 11:21 PM, Stephen Warren wrote:
>>> On 03/08/2013 06:52 AM, Laxman Dewangan wrote:
>>>> NVIDIA's Tegra114 has 32 channels APB DMA controller. Add DT entry for
>>>> APB DMA controllers and make it compatible with
>>>> "nvidia,tegra114-apbdma".
>>>> diff --git a/arch/arm/boot/dts/tegra114.dtsi
>>>> b/arch/arm/boot/dts/tegra114.dtsi
>>>> + apbdma: dma {
>>>> + compatible = "nvidia,tegra114-apbdma";
>>> So I know that the Tegra114 HW has a new channel-pause feature, which
>>> the driver /can/ use. However, if the driver didn't know about that
>>> feature, and continued to use the global-pause feature, would it still
>>> work fine?
>>>
>>> In other words, is the Tegra114 HW 100% backwards-compatible with the
>>> Tegra30 HW, it's just that there are new features that SW could
>>> optionally use?
>>>
>>> If that is true, then we should also include "nvidia,tegra30-apbdma" in
>>> the compatible value.
>> Tegra114 HW is not compatible with the tegra30 as with global pause, it
>> is not able to write into the dma register in T114. On t114, the dma
>> register is clock gated with global enable/disable.
> Interesting. In that case, the compatible value above is entirely
> correct. Thanks for the explanation. It might be worth mentioning this
> in the commit description.
I can describe here as I am going to respin the patches anyhow.
However, I have already explain this in the driver commit when porting
for T114.
next prev parent reply other threads:[~2013-03-08 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 13:52 [PATCH 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-08 13:52 ` [PATCH 1/5] ARM: DT: tegra114: add APB DMA controller DT entry Laxman Dewangan
2013-03-08 17:51 ` Stephen Warren
2013-03-08 18:06 ` Laxman Dewangan
2013-03-08 18:41 ` Stephen Warren
2013-03-08 18:46 ` Laxman Dewangan [this message]
2013-03-08 13:52 ` [PATCH 2/5] ARM: DT: tegra114: Add i2c " Laxman Dewangan
2013-03-08 13:53 ` [PATCH 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller Laxman Dewangan
2013-03-08 17:54 ` Stephen Warren
2013-03-08 18:04 ` Laxman Dewangan
2013-03-08 18:40 ` Stephen Warren
2013-03-08 13:53 ` [PATCH 4/5] ARM: DT: tegra114: add KBC controller DT entry Laxman Dewangan
2013-03-08 18:04 ` Stephen Warren
2013-03-08 18:14 ` Laxman Dewangan
2013-03-08 18:42 ` Stephen Warren
2013-03-08 13:53 ` [PATCH 5/5] ARM: DT: tegra114: Add spi " Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A3200.8070905@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).