* [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static'
@ 2013-03-10 1:59 Chen Gang
2013-03-11 1:26 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-03-10 1:59 UTC (permalink / raw)
To: linux-arm-kernel
better using 'static const' instead of 'const static'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/kernel/smp_twd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 3f25650..ef3e499 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
}
#ifdef CONFIG_OF
-const static struct of_device_id twd_of_match[] __initconst = {
+static const struct of_device_id twd_of_match[] __initconst = {
{ .compatible = "arm,cortex-a9-twd-timer", },
{ .compatible = "arm,cortex-a5-twd-timer", },
{ .compatible = "arm,arm11mp-twd-timer", },
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static'
2013-03-10 1:59 [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static' Chen Gang
@ 2013-03-11 1:26 ` Rob Herring
2013-03-11 5:02 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2013-03-11 1:26 UTC (permalink / raw)
To: linux-arm-kernel
On 03/09/2013 07:59 PM, Chen Gang wrote:
>
> better using 'static const' instead of 'const static'
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/kernel/smp_twd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index 3f25650..ef3e499 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
> }
>
> #ifdef CONFIG_OF
> -const static struct of_device_id twd_of_match[] __initconst = {
> +static const struct of_device_id twd_of_match[] __initconst = {
This will go away with conversion to use CLKSRC_OF.
Rob
> { .compatible = "arm,cortex-a9-twd-timer", },
> { .compatible = "arm,cortex-a5-twd-timer", },
> { .compatible = "arm,arm11mp-twd-timer", },
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static'
2013-03-11 1:26 ` Rob Herring
@ 2013-03-11 5:02 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-03-11 5:02 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?03?11? 09:26, Rob Herring ??:
> On 03/09/2013 07:59 PM, Chen Gang wrote:
>> >
>> > better using 'static const' instead of 'const static'
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm/kernel/smp_twd.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>> > index 3f25650..ef3e499 100644
>> > --- a/arch/arm/kernel/smp_twd.c
>> > +++ b/arch/arm/kernel/smp_twd.c
>> > @@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
>> > }
>> >
>> > #ifdef CONFIG_OF
>> > -const static struct of_device_id twd_of_match[] __initconst = {
>> > +static const struct of_device_id twd_of_match[] __initconst = {
> This will go away with conversion to use CLKSRC_OF.
excuse me, I am not quite familiar with ARM, so I do not quite
understand what you said.
could you describe it with more details ?
and how about this patch ?
a. do not need this patch.
b. or this patch need improving.
c. or this patch is ok, can be applied.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-11 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 1:59 [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static' Chen Gang
2013-03-11 1:26 ` Rob Herring
2013-03-11 5:02 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox