From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static'
Date: Mon, 11 Mar 2013 13:02:59 +0800 [thread overview]
Message-ID: <513D6583.8040506@asianux.com> (raw)
In-Reply-To: <513D32E3.1080101@gmail.com>
? 2013?03?11? 09:26, Rob Herring ??:
> On 03/09/2013 07:59 PM, Chen Gang wrote:
>> >
>> > better using 'static const' instead of 'const static'
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm/kernel/smp_twd.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>> > index 3f25650..ef3e499 100644
>> > --- a/arch/arm/kernel/smp_twd.c
>> > +++ b/arch/arm/kernel/smp_twd.c
>> > @@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
>> > }
>> >
>> > #ifdef CONFIG_OF
>> > -const static struct of_device_id twd_of_match[] __initconst = {
>> > +static const struct of_device_id twd_of_match[] __initconst = {
> This will go away with conversion to use CLKSRC_OF.
excuse me, I am not quite familiar with ARM, so I do not quite
understand what you said.
could you describe it with more details ?
and how about this patch ?
a. do not need this patch.
b. or this patch need improving.
c. or this patch is ok, can be applied.
thanks.
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-03-11 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 1:59 [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static' Chen Gang
2013-03-11 1:26 ` Rob Herring
2013-03-11 5:02 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D6583.8040506@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox