linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] memory: emif: use restart if power_off not present when out of spec
Date: Mon, 11 Mar 2013 11:09:57 +0530	[thread overview]
Message-ID: <513D6E2D.4040805@ti.com> (raw)
In-Reply-To: <1362978365-5593-6-git-send-email-lokeshvutla@ti.com>

On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Nishanth Menon <nm@ti.com>
> 
> Some machine or kernel variants might have missed implementation
> of power off handlers. We DONOT want to let the system be in
> "out of spec" state in this condition. So, WARN and attempt
> a machine restart in the hopes of clearing the out-of-spec
> temperature condition.
> 
> NOTE: This is not the safest option, but safer than leaving the
> system in unstable conditions.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  drivers/memory/emif.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 927fb55..02a94fc 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -25,6 +25,7 @@
>  #include <linux/module.h>
>  #include <linux/list.h>
>  #include <linux/spinlock.h>
> +#include <linux/pm.h>
>  #include <memory/jedec_ddr.h>
>  #include "emif.h"
>  #include "of_memory.h"
> @@ -1011,7 +1012,13 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
>  
>  	if (emif->temperature_level == SDRAM_TEMP_VERY_HIGH_SHUTDOWN) {
>  		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
> -		kernel_power_off();
Extra line here would be good here.
> +		/* If we have Power OFF ability, use it, else try restarting */
> +		if (pm_power_off) {
> +			kernel_power_off();
> +		} else {
> +			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
> +			kernel_restart("SDRAM Over-temp Emergency restart");
> +		}
>  		return IRQ_HANDLED;
>  	}
>  
Otherwise,
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

  reply	other threads:[~2013-03-11  5:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  5:05 [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Lokesh Vutla
2013-03-11  5:05 ` [PATCH 1/8] memory: emif: Correct the lpmode timeout calculation Lokesh Vutla
2013-03-11  5:34   ` Santosh Shilimkar
2013-03-11  5:05 ` [PATCH 2/8] memory: emif: setup LP settings on freq update Lokesh Vutla
2013-03-11  5:34   ` Santosh Shilimkar
2013-03-11  5:06 ` [PATCH 3/8] memory: emif: handle overflow for timing for LP mode Lokesh Vutla
2013-03-11  5:35   ` Santosh Shilimkar
2013-03-11  5:06 ` [PATCH 4/8] memory: emif: Handle devices which are not rated for >85C Lokesh Vutla
2013-03-11  5:38   ` Santosh Shilimkar
2013-03-11  5:06 ` [PATCH 5/8] memory: emif: use restart if power_off not present when out of spec Lokesh Vutla
2013-03-11  5:39   ` Santosh Shilimkar [this message]
2013-03-11  5:06 ` [PATCH 6/8] memory: emif: fix timings initialization issue Lokesh Vutla
2013-03-11  5:44   ` Santosh Shilimkar
2013-03-11  5:06 ` [PATCH 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla
2013-03-11  5:50   ` Santosh Shilimkar
2013-03-11 11:10     ` Lokesh Vutla
2013-03-11  5:06 ` [PATCH 8/8] memory: emif: Load the correct custom config values from dt Lokesh Vutla
2013-03-11  5:51   ` Santosh Shilimkar
2013-03-15 18:08 ` [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Greg KH
2013-03-16  6:13   ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513D6E2D.4040805@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).