From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: tegra: expose chip ID and revision
Date: Wed, 13 Mar 2013 11:45:52 -0600 [thread overview]
Message-ID: <5140BB50.8080004@wwwdotorg.org> (raw)
In-Reply-To: <1363168080-12697-1-git-send-email-dahuang@nvidia.com>
On 03/13/2013 03:48 AM, Danny Huang wrote:
> Expose Tegra chip ID and revision in /sys/devices/soc for user mode
> usage
> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
> static void __init tegra_dt_init(void)
> {
> + struct device *parent = NULL;
> + struct soc_device *soc_dev;
> + struct soc_device_attribute *soc_dev_attr;
Since Russell asked you to redo the patch anyway, I'd prefer that
variables be declared in the order they're used. So, soc_dev_attr, then
soc_dev, then parent.
prev parent reply other threads:[~2013-03-13 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 9:48 [PATCH v3] ARM: tegra: expose chip ID and revision Danny Huang
2013-03-13 10:09 ` Russell King - ARM Linux
2013-03-13 17:45 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140BB50.8080004@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox