From mboxrd@z Thu Jan 1 00:00:00 1970 From: r.sricharan@ti.com (Sricharan R) Date: Thu, 14 Mar 2013 09:28:51 +0530 Subject: [PATCH V6] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses In-Reply-To: <51261288.5030806@ti.com> References: <1360574009-12429-1-git-send-email-r.sricharan@ti.com> <20130211131230.GA5676@MacBook-Pro.local> <5118F796.3080308@ti.com> <51261288.5030806@ti.com> Message-ID: <51414AFB.9080403@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 21 February 2013 05:56 PM, R Sricharan wrote: > Hi, > On Monday 11 February 2013 07:22 PM, R Sricharan wrote: >> Hi Russell, >> >> On Monday 11 February 2013 06:42 PM, Catalin Marinas wrote: >>> On Mon, Feb 11, 2013 at 09:13:29AM +0000, R Sricharan wrote: >>>> +static void __init alloc_init_pmd(pud_t *pud, unsigned long addr, >>>> + unsigned long end, phys_addr_t phys, >>>> + const struct mem_type *type) >>>> +{ >>>> + pmd_t *pmd = pmd_offset(pud, addr); >>>> + unsigned long next; >>>> + >>>> + do { >>>> /* >>>> - * No need to loop; pte's aren't interested in the >>>> - * individual L1 entries. >>>> + * With LPAE, we must loop over to map >>>> + * all the pmds for the given range. >>>> */ >>>> - alloc_init_pte(pmd, addr, end, __phys_to_pfn(phys), type); >>>> - } >>>> + next = pmd_addr_end(addr, end); >>>> + >>>> + /* >>>> + * Try a section mapping - end, addr and phys must all be >>>> + * aligned to a section boundary. >>>> + */ >>> >>> Should this read "next, addr and phys" instead of "end..."? >>> >>> Otherwise: >>> >>> Reviewed-by: Catalin Marinas >>> >> Can I put this in to patch system ? > > Ping.. > > Regards, > Sricharan Ping again.. Regards, Sricharan