linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
Date: Thu, 14 Mar 2013 17:13:08 +0530	[thread overview]
Message-ID: <5141B7CC.7000700@ti.com> (raw)
In-Reply-To: <1363257158-11615-3-git-send-email-avinashphilip@ti.com>

On 3/14/2013 4:02 PM, Philip Avinash wrote:
> ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> support for da850.
> 
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> :100644 100644 131e8c1... fcbd3c1... M	Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> :100644 100644 22e96e2... e0d96c8... M	drivers/pwm/pwm-tiecap.c
>  .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
>  drivers/pwm/pwm-tiecap.c                           |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> index 131e8c1..fcbd3c1 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> @@ -1,7 +1,7 @@
>  TI SOC ECAP based APWM controller
>  
>  Required properties:
> -- compatible: Must be "ti,am33xx-ecap"
> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
>  - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
>    First cell specifies the per-chip index of the PWM to use, the second
>    cell is the period in nanoseconds and bit 0 in the third cell is used to
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 22e96e2..e0d96c8 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
>  
>  static const struct of_device_id ecap_of_match[] = {
>  	{ .compatible	= "ti,am33xx-ecap" },
> +	{ .compatible	= "ti,da850-ecap" },
>  	{},

You add a new compatible, but don't really show any changes in driver in
this series. So why can't we simply use ti,am33xx-ecap on DA850 too?

Thanks,
Sekhar

  reply	other threads:[~2013-03-14 11:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 10:32 [PATCH 0/3] Davinci support for EHRPWM & ECAP Philip Avinash
2013-03-14 10:32 ` [PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices Philip Avinash
2013-03-14 11:39   ` Sekhar Nori
2013-03-14 12:54     ` Philip, Avinash
2013-03-14 15:11       ` Thierry Reding
2013-03-14 10:32 ` [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC Philip Avinash
2013-03-14 11:43   ` Sekhar Nori [this message]
2013-03-14 12:54     ` Philip, Avinash
2013-03-14 15:44     ` Peter Korsgaard
2013-03-15  4:25       ` Sekhar Nori
2013-03-14 10:32 ` [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree " Philip Avinash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5141B7CC.7000700@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).